Repository navigation
docs(brain): record the Effect abort signal, the provider tabs and the new pending changesets - #49
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Shepherd review at Intent. Brain notes only, recording #46, #48 and the changesets from #33, #37, #42 and #46. The diff touches only the five notes the description names and does nothing it does not say. Claims checked against
Defect: Optional, not part of the verdict: the "Majors" line in VERDICT: NO-GO. Move the "A failed lookup renders |
… say why effect-v4 covers five clients
|
Review fix at 67453cc, brain notes only.
Checks: Markdown only, so no local lint applies ( What would show this wrong: a sixth package in |
|
Fast-path review of #49. The openapi checkout is not on this runner, so I checked each statement against the merged diffs of #46 and #48, which are the code changes this brain update describes. What matches:
What I could not check:
No secrets, credentials, customer data or personal details appear in the diff. VERDICT: GO Every statement I could check against the merged #46 and #48 diffs matches, and the two points I could not check are a note for the next release, not a claim this change makes false. |
|
HQ merge gate on #49: Landing this
|
Brain maintenance shift. Brain notes only, no code.
Merges since the last brain sweep (#36) that changed what the notes describe without updating them:
brain/architecture/shared-utils.md: Abort the request when an Effect operation is interrupted #46 made the Effect proxies pass theEffect.tryPromiseAbortSignal to the operation asconfig.signal(packages/openapi-utils/src/effect/proxy.ts), read only own keys, and letmakeApiLayeracceptfetchImpl(src/effect/errors.ts).brain/development/testing.md: the Abort the request when an Effect operation is interrupted #46 cases insrc/effect/proxy.test.ts(abort on timeout,fetchImpl,Object.prototypekeys).brain/architecture/website.md: Fix provider tab hydration mismatch, wrapping and stale stored tab #48, the provider tabs restore theactiveProviderTablocalStorage value after mount (apps/openapi/src/components/provider-card.tsx), and the committedapps/openapi/AGENTS.md.brain/development/release.md:.changeset/now holds 57 changesets (listing on this commit), addingeffect-error-message-*(Surface the API's error message in ApiError and unit-test the Effect proxy #33),fetcher-failure-detail-*(Keep the cause and the response body when a client request fails #37),dts-private-types-*(Export the fetcher types the v0-api and keycloak-api declarations reference #42) andeffect-abort-signal-*(Abort the request when an Effect operation is interrupted #46), all patches.brain/plans/index.md: the first release list gains the same four, and the open issue check is redated (13 re-publishes private repository names in hq-stack.yml; the stack renderer needs fixing in sferarc/hq #15 is still the only open issue).Deleted nothing: every note still describes something that exists.
Not in this PR, on purpose: #34 is open and already covers #17, #23 and #24 in
shared-utils.mdandpackages.md. The two touch different lines ofshared-utils.md.Not checked: the npm versions in the "Current state" section of
release.md, sincenpm viewwas not permitted in this session. That section keeps its 2026-10-14 date rather than claiming a newer check.Checks: Markdown only, and biome does not lint Markdown (
biome.json), so no local check applies. CI'sCheckjob still has to run. No em or en dashes in the diff.What would show this wrong: any cited path or behaviour not matching
main, or a changeset count other than 57 excludingREADME.mdandconfig.json.