Skip to content

Add initial Markdown support - #44

Open
strzibny wants to merge 2 commits into
masterfrom
markdown
Open

Add initial Markdown support#44
strzibny wants to merge 2 commits into
masterfrom
markdown

Conversation

@strzibny

@strzibny strzibny commented Aug 18, 2026

Copy link
Copy Markdown

This PR adds the basic support for our new Markdown Output feature, namely by introducing getMd and getMdBySearchId.

Comment thread scripts/build_npm.ts
@@ -1,4 +1,4 @@
import { build, emptyDir } from "https://deno.land/x/dnt@0.40.0/mod.ts";
import { build, emptyDir } from "@deno/dnt";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes related to supporting Markdown?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just replacing the hard-coded version in deno.json. I believe it has nothing to do with the Markdown feature itself.

https://github.com/denoland/dnt

@hilmanski

Copy link
Copy Markdown
Contributor

Thanks, @strzibny for the work here. I've tested it from a user perspective.

The getMd works great:

CleanShot 2026-09-08 at 06 16 38
  • Tested on an API outside Google; it also works well.

Test getMdBySearchID also works well:

CleanShot 2026-09-08 at 06 22 25

For an async sample in Markdown in the README file:

CleanShot 2026-09-08 at 06 27 26
  • maybe we should use getMd({..}) instead on getJSON as that works as well.

I also want to suggest adding early on in the README that we support both JSON and Markdown.

@hilmanski

Copy link
Copy Markdown
Contributor

Maybe, @zyc9012 or @tanysheng can have a final review for code-wise before merging.

@strzibny

strzibny commented Sep 8, 2026

Copy link
Copy Markdown
Author

Good point, I separated Deno to a new PR #49 and I'll rebase this afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants