Conversation
| @@ -1,4 +1,4 @@ | |||
| import { build, emptyDir } from "https://deno.land/x/dnt@0.40.0/mod.ts"; | |||
| import { build, emptyDir } from "@deno/dnt"; | |||
Contributor
There was a problem hiding this comment.
Are these changes related to supporting Markdown?
Contributor
There was a problem hiding this comment.
It's just replacing the hard-coded version in deno.json. I believe it has nothing to do with the Markdown feature itself.
Contributor
|
Thanks, @strzibny for the work here. I've tested it from a user perspective. The
Test
For an async sample in Markdown in the README file:
I also want to suggest adding early on in the README that we support both JSON and Markdown. |
Contributor
|
Maybe, @zyc9012 or @tanysheng can have a final review for code-wise before merging. |
Author
|
Good point, I separated Deno to a new PR #49 and I'll rebase this afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR adds the basic support for our new Markdown Output feature, namely by introducing
getMdandgetMdBySearchId.