Skip to content

fix: align public readback with article visibility - #66

Merged
seoJing merged 1 commit into
mainfrom
fix/public-readback-visibility-20261112
Nov 12, 2026
Merged

seoJing merged 1 commit into
mainfrom
fix/public-readback-visibility-20261112

Conversation

@seoJing

@seoJing seoJing commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Why

The Worker in #65 deployed successfully, but main CI run 43185301126 failed at the final public readback step. The readback script still required 201 published articles and treated two intentionally private series entries as public. Remote D1 currently has 173 public articles; those two routes correctly return 404.

Changes

  • Set the public-index floor to the currently verified 173 entries and retain duplicate/invalid/missing checks.
  • Replace private article content sentinels with three real public pages, checking document rendering plus quiz, code, and image signals.
  • Explicitly reject exposure of either intentionally private slug in the index or via its HTML route (must be 404).
  • Run probes sequentially to avoid concurrent cold SSR work on the free-tier Worker.
  • Update the 1102 report with post-deployment CPU/GraphQL and Chrome Performance observations, including cold-miss and warm-cache caveats.

Verification

  • Local lint, format, coverage, build and six readback tests passed.
  • Corrected readback against https://seojing.com: pass on first attempt; 173 indexed public articles; 3 public page content checks passed; 2 private pages returned 404.
  • Independent read-only review accepted the script; targeted second review accepted the corrected report with no blocker.
  • .github/workflows/ci.yml has no override that still forces 201.

This PR repairs the post-deploy verification gate; it does not alter production Worker runtime behavior. The first main CI run remains red until this separately reviewed change merges and the next main CI passes.

Co-authored-by: seoJing <68586661+seoJing@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 12692fc and abf3210.

Files selected for processing: 3

  • apps/web/scripts/check-public-blog-readback.mjs
  • apps/web/scripts/check-public-blog-readback.test.mjs
  • docs/worker-1102-performance-2026-11-12.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@seoJing
seoJing merged commit 83c3fff into main Nov 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant