Repository navigation
phMod types - #333
Merged
Merged
phMod types#333
Conversation
include other phMod types
make last value unnecessary, as in the comments otherwise if final freq is left off this is always true
update setFreq to use last oscil for all frequencies above the penultimate cutoff, regardless of if the last oscillator has a cutoff frequency set
Contributor
Author
|
only commit c7479c6 matters |
Collaborator
|
Looks good to me, correcting something that got forgotten when transitioning to FixMath. Reading it, I ended up wondering if the Would be good if you can squash all these commits into one. Thanks! |
Collaborator
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
int8_t phMod(SFix<NI,NF,RANGE> phmod_proportion) and
int8_t phMod(SFix<15,16> phmod_proportion) to metaoscil