Conversation
…ed docs and tests
joe-dw
marked this pull request as ready for review
September 3, 2026 16:09
james-d-mitchell
changed the title
EdgesWithRange/Source, PathsWithRange/Source, and Positive/NegativePath for graph inverse semigroups
james-d-mitchell
requested changes
Sep 4, 2026
james-d-mitchell
left a comment
james-d-mitchell
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @joe-dw, this is better, but still needs some improvements, and corrections. Please also try to have meaningful names for PRs in future, I edited this PR title to be more accurate, and possibly meaningful for future readers.
… behaviour of Paths/Edges with Source/Range to now return [] when given a non-vertex element
GAP 4.17 changes PreImagesSet: a generic method now checks that the argument is a subset of the range and returns the preimage of its intersection with the image. With that method, PreImagesSet no longer signals an error for elements without preimages, which the tests expect, and the error for elements outside the range changes. Install a method for semigroup homomorphisms by images that performs the range check with the package's own error message and otherwise delegates to PreImagesElm, so behaviour is the same with all supported GAP versions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…roups with at most one vertex. (semigroups#1216)
joe-dw
force-pushed
the
pathsWithSourceRange
branch
from
September 9, 2026 11:45
5555d23 to
c46771e
Compare
Collaborator
Author
Collaborator
Author
|
I'm going to change how EdgesWithRange/Source works actually, because there's no reason it can't work with infinite but finitely generated semigroups. Only PathsWithRange/Source |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a smaller version of PR #1204 containing only a few functions and the related documentation and tests.