Skip to content

fix(simhash): preserve UTF-8 during native SimHash normalization (ticket-021) - #34

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/021-project-job-a0c469a6
Oct 28, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/021-project-job-a0c469a6

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Closes #29

  • Preserve valid UTF-8 character boundaries in clean_code_for_fuzzy (packages/redup-fast-hash/src/simhash.rs) so native SimHash matches the Python reference implementation on Unicode source text without panics.
  • Add embedded Rust regression vectors and a Python conformance test (tests/test_tokens_hasher_rust.py) that builds the candidate Rust binary and verifies parity across Unicode vectors.

Governed ticket: ticket-021.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 6aa43cbda997e6ea277daffb649fc4394f2b0bec.

Ticket: ticket-021
Correlation ID: local-semcod-redup-pr-34-ticket-021
Model: ollama/qwen3-coder:30b
Advisory LLM review: LLM_UNAVAILABLE
Reason: litellm.NotFoundError: OllamaException - 404 page not found
This approval rests on the deterministic checks alone; no advisory opinion was recorded for this head.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 364616fdb1069e2065d1a59d2d30bfc076a1e7b9...6aa43cbda997e6ea277daffb649fc4394f2b0bec
Change digest: 7a4f5ebdf4be1b9390e98c85074e24f1e9e5d93085bcceb62a90fb68ea674e47
Score: 48/100 (M), estimated 50 min, split recommended: true
Affected services/components: packages/redup-fast-hash

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":443,"base_sha":"364616fdb1069e2065d1a59d2d30bfc076a1e7b9","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"7a4f5ebdf4be1b9390e98c85074e24f1e9e5d93085bcceb62a90fb68ea674e47","comparison":"364616fdb1069e2065d1a59d2d30bfc076a1e7b9...6aa43cbda997e6ea277daffb649fc4394f2b0bec","deletions":4,"file_count":4,"files":["packages/redup-fast-hash/src/simhash.rs","project/ticket-021/README.md","project/ticket-021/intent.json","tests/test_tokens_hasher_rust.py"],"head_sha":"6aa43cbda997e6ea277daffb649fc4394f2b0bec","service_count":1,"services":["packages/redup-fast-hash"]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":50,"within_budget":false},"impact":{"components":["packages/redup-fast-hash","project","tests"],"files":["packages/redup-fast-hash/src/simhash.rs","project/ticket-021/README.md","project/ticket-021/intent.json","tests/test_tokens_hasher_rust.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":14,"name":"Implement packages/redup-fast-hash","scope":["packages/redup-fast-hash"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-021"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-021: fix(simhash): preserve UTF-8 during native SimHash normalization (ticket-021)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 50m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-021-1115
TICKET ticket-021
HEAD_SHA 6aa43cbda997e6ea277daffb649fc4394f2b0bec
CORRELATION_ID local-semcod-redup-pr-34-ticket-021
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","test (3.10)=PASS","governance / enforce=PASS","test (3.13)=PASS"]
INPUT required_checks = ["test (3.10)","test (3.13)"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/redup","pull_request":34,"head_sha":"6aa43cbda997e6ea277daffb649fc4394f2b0bec","base_sha":"364616fdb1069e2065d1a59d2d30bfc076a1e7b9","diff_sha256":"54bba53ac1292ccccf2b054aa3b52735fccb83cd88f553e9fde5cabd37d77ce6"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["packages/redup-fast-hash/src/simhash.rs","project/ticket-021/README.md","project/ticket-021/intent.json","tests/test_tokens_hasher_rust.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"364616fdb1069e2065d1a59d2d30bfc076a1e7b9","head_sha":"6aa43cbda997e6ea277daffb649fc4394f2b0bec","change_digest":"7a4f5ebdf4be1b9390e98c85074e24f1e9e5d93085bcceb62a90fb68ea674e47","score":48,"complexity":"M","estimated_minutes":50,"split_recommended":true,"services":["packages/redup-fast-hash"],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "" MODEL "ollama/qwen3-coder:30b"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit e8d2ca2 into main Oct 28, 2026
4 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/021-project-job-a0c469a6 branch October 28, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve UTF-8 and Python/native SimHash parity for Unicode source text

1 participant