Repository navigation
test(radar): make bulk deadline test independent of host load (ticket-257) - #318
Conversation
There was a problem hiding this comment.
Validator approval after policy checks for exact head 653a9898e230dafe21b1344fa63739a094476640.
Ticket: ticket-257
Correlation ID: local-semcod-planfile-pr-318-ticket-257
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). The test-only change removes startup-time sensitivity by making the first fake-radar call immediate and subsequent calls block, while preserving assertions that the first ticket is enriched and all remaining tickets and operational events survive the bulk deadline. All protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: ff2193f8865ee2f83b0171d1cd0e44dd0a8a225f...653a9898e230dafe21b1344fa63739a094476640
Change digest: 2aa039f9d31d4190cf5cfdff1611ed6f305307bb020ad89deb2e70bb351af4dd
Score: 56/100 (M), estimated 60 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":80,"base_sha":"ff2193f8865ee2f83b0171d1cd0e44dd0a8a225f","binary_files":0,"categories":{"configuration":1,"docs":2,"tests":1},"change_digest":"2aa039f9d31d4190cf5cfdff1611ed6f305307bb020ad89deb2e70bb351af4dd","comparison":"ff2193f8865ee2f83b0171d1cd0e44dd0a8a225f...653a9898e230dafe21b1344fa63739a094476640","deletions":4,"file_count":4,"files":["project/TICKETS.md","project/ticket-257/README.md","project/ticket-257/intent.json","tests/test_ticket_radar.py"],"head_sha":"653a9898e230dafe21b1344fa63739a094476640","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":60,"within_budget":false},"impact":{"components":["1","2","6","project","tests"],"files":["1/4","2/3","6/6","project/TICKETS.md","project/ticket-257/README.md","project/ticket-257/intent.json","tests/test_ticket_radar.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":56,"split":{"parts":[{"estimated_minutes":10,"name":"Implement 1","scope":["1"]},{"estimated_minutes":10,"name":"Implement 2","scope":["2"]},{"estimated_minutes":10,"name":"Implement 6","scope":["6"]},{"estimated_minutes":10,"name":"Implement project","scope":["project"]},{"estimated_minutes":10,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-257"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-257: test(radar): make bulk deadline test independent of host load (ticket-257)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 60m</text></svg>DECISION D-257-4290
TICKET ticket-257
HEAD_SHA 653a9898e230dafe21b1344fa63739a094476640
CORRELATION_ID local-semcod-planfile-pr-318-ticket-257
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","freshness=PASS","test (3.10)=PASS","test (3.13)=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","ci-loop=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":318,"head_sha":"653a9898e230dafe21b1344fa63739a094476640","base_sha":"ff2193f8865ee2f83b0171d1cd0e44dd0a8a225f","diff_sha256":"0f5d0046c457ec99aacf957e406cf5ca9c2768630728c041cfd07ef001f4c393"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/TICKETS.md","project/ticket-257/README.md","project/ticket-257/intent.json","tests/test_ticket_radar.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"ff2193f8865ee2f83b0171d1cd0e44dd0a8a225f","head_sha":"653a9898e230dafe21b1344fa63739a094476640","change_digest":"2aa039f9d31d4190cf5cfdff1611ed6f305307bb020ad89deb2e70bb351af4dd","score":56,"complexity":"M","estimated_minutes":60,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Test-only. test_failure_bulk_deadline_preserves_remaining_tickets used a 0.35 s deadline and 0.2 s fake radar, so subprocess start-up decided the result (1/4 passes on PR 315, 2/3 on main at load 50-70). The fake radar now answers its first call immediately and blocks later calls until a 2.0 s bulk deadline. 6/6 consecutive passes at load >15; full tests/test_ticket_radar.py: 80 passed.