Repository navigation
fix(health): accelerate safe YAML analysis and preserve deadlines (ticket-256) - #315
Conversation
1b7cf96 to
89467b4
Compare
There was a problem hiding this comment.
Validator approval after policy checks for exact head 9ffa518f9bd0dc133c8929a28d2ee0906e9f4733.
Ticket: ticket-256
Correlation ID: local-semcod-planfile-pr-315-ticket-256
Model: openai/cursor-auto
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). The visible changes safely accelerate YAML parsing through the existing FastLoader, preserve SafeLoader-compatible diagnostics on YAML errors, and correctly propagate TimeoutError from YAML and text parsers so deadlines cannot be misreported as healthy results. Required protected checks all pass. | The visible chunk adds focused regression coverage for SafeLoader/CSafeLoader parity, refusal to execute unsafe YAML tags, malformed workflow diagnostics, large-file issue preservation, and parser-error diagnostic compatibility. All protected required checks passed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.
Actual PR impact radar
Exact range: 96205d1ec0f76c96b8ed2e3d657c4d7457e8861a...9ffa518f9bd0dc133c8929a28d2ee0906e9f4733
Change digest: 577756190dd90ced150d30cee0161c921e53ff70d7144704a865ac08b830c070
Score: 64/100 (L), estimated 76 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":254,"base_sha":"96205d1ec0f76c96b8ed2e3d657c4d7457e8861a","binary_files":0,"categories":{"code":2,"configuration":1,"docs":1,"tests":2},"change_digest":"577756190dd90ced150d30cee0161c921e53ff70d7144704a865ac08b830c070","comparison":"96205d1ec0f76c96b8ed2e3d657c4d7457e8861a...9ffa518f9bd0dc133c8929a28d2ee0906e9f4733","deletions":2,"file_count":6,"files":["planfile/analysis/parsers/text_parser.py","planfile/analysis/parsers/yaml_parser.py","project/ticket-256/README.md","project/ticket-256/intent.json","tests/test_health_check.py","tests/test_yaml_analysis_loader.py"],"head_sha":"9ffa518f9bd0dc133c8929a28d2ee0906e9f4733","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":4,"scope":3,"uncertainty":3,"validation":2},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":76,"within_budget":false},"impact":{"components":["A615file","planfile","project","tests"],"files":["A615file/3.996MB","planfile/analysis/parsers/text_parser.py","planfile/analysis/parsers/yaml_parser.py","project/ticket-256/README.md","project/ticket-256/intent.json","tests/test_health_check.py","tests/test_yaml_analysis_loader.py"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":64,"split":{"parts":[{"estimated_minutes":17,"name":"Implement A615file","scope":["A615file"]},{"estimated_minutes":17,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":17,"name":"Implement project","scope":["project"]},{"estimated_minutes":17,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-256"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-256: fix(health): accelerate safe YAML analysis and preserve deadlines (ticket-256)</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 97,53 79,85 54,78 31,53" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 76m</text></svg>DECISION D-256-9866
TICKET ticket-256
HEAD_SHA 9ffa518f9bd0dc133c8929a28d2ee0906e9f4733
CORRELATION_ID local-semcod-planfile-pr-315-ticket-256
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["notify=PASS","test (3.13)=PASS","governance / remote lifecycle=PASS","test (3.10)=PASS","freshness=PASS","ci-loop=PASS","governance / enforce=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["ci-loop","notify","freshness","governance / remote lifecycle","governance / enforce","test (3.10)","test (3.13)","onedev/local-verify"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/planfile","pull_request":315,"head_sha":"9ffa518f9bd0dc133c8929a28d2ee0906e9f4733","base_sha":"96205d1ec0f76c96b8ed2e3d657c4d7457e8861a","diff_sha256":"5c326f6e31b24a7a90a21310e7e6ae1dd7579ba2d2c3965a15a6c44d6875d1a4"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["planfile/analysis/parsers/text_parser.py","planfile/analysis/parsers/yaml_parser.py","project/ticket-256/README.md","project/ticket-256/intent.json","tests/test_health_check.py","tests/test_yaml_analysis_loader.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"96205d1ec0f76c96b8ed2e3d657c4d7457e8861a","head_sha":"9ffa518f9bd0dc133c8929a28d2ee0906e9f4733","change_digest":"577756190dd90ced150d30cee0161c921e53ff70d7144704a865ac08b830c070","score":64,"complexity":"L","estimated_minutes":76,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
Full verification of #314 hit the existing eight-second health deadline while scanning the repository on Python3.11 with coverage. YAML parsing dominated that analysis. Health now reuses the existing safe libyaml loader with its pure-Python fallback; malformed inputs use the original safe parser so diagnostic text is preserved. YAML and text parsers also propagate deadlines instead of converting them to partial healthy output.
The eight-second deadline and every required check are retained. No runtime dependency or deployment is included.
Validation:54affected tests pass with Testless coverage, including two timeout regressions reproduced before correction, safe-loader parity, unsafe-tag refusal, aliases, recursive YAML and diagnostic compatibility. A615file/3.996MB scan produces byte-identical results across both loaders; latest unprofiled local observation was0.852s versus1.964s. Ruff and native governance pass. Timings describe this host observation and do not guarantee completion under arbitrary load.
CI dependency for #314; related historical #101. Native ticket:
ticket-256; owner-local Planfile record:PLF-20016. Protected verification of this exact head merged with current main and independent Validator publication remain required. After merge, resume #314 against the updated base without resetting its failed attempt history.