Skip to content

fix(ticket-133): read a Planfile task without status as open - #158

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/133-read-planfile-task-without-status-as-open
Oct 28, 2026
Merged

ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/133-read-planfile-task-without-status-as-open

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

semcod/goal/planfile.yaml contains a legacy task Q01 without a status field. monag resume read it as unknown, so the queue reported unknown_statuses=1. autonom fleet admission then refused every Willman campaign for semcod/goal with project_intake_refused:observe,ambiguous_queue_state; a campaign started from OpenCode was refused this way within seconds.

Planfile itself creates tasks with status='open' (planfile/core/decompose.py), and monag now uses the same default for a missing status. Explicit values outside the known sets still count as unknown, and conflict detection is unchanged.

  • python -m unittest tests.test_resume: 36 passed (new: test_task_without_status_is_open_not_unknown)
  • ./project/governance-check.sh: GOV-PASS

🤖 Generated with Claude Code

Planfile creates tasks as open; a legacy task without a status field marked
the whole queue ambiguous and blocked autonomous intake for semcod/goal.

Co-Authored-By: Claude <noreply@anthropic.com>

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 2c410b05a27f110e70034940d1f269f1c0fe3b9f.

Ticket: ticket-133
Correlation ID: local-semcod-monag-pr-158-ticket-133
Model: openai/cursor-auto
Reviewed diff chunks: 1
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 1 diff chunk(s). The required checks pass and the missing-status regression is covered, but the implementation changes behavior for more than an absent field.
Advisory findings: Using item.get('status') or 'open' treats explicitly configured null, empty-string, and other falsy status values as open. This can hide malformed or ambiguous explicit statuses and conflicts with the stated scope that only a missing status defaults to open while explicit unknown values remain unknown. Distinguish an absent key from an explicitly falsy value and add regression coverage for explicit null/empty status values.
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: not_required; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: d50d1bf7d55b304e603cb5e4438cbcbd904f8507...2c410b05a27f110e70034940d1f269f1c0fe3b9f
Change digest: 5fbc903022031e494807ee0ff2f15358eea3b243727fda591981cce72b862215
Score: 60/100 (L), estimated 71 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":104,"base_sha":"d50d1bf7d55b304e603cb5e4438cbcbd904f8507","binary_files":0,"categories":{"code":1,"configuration":1,"docs":1,"tests":1},"change_digest":"5fbc903022031e494807ee0ff2f15358eea3b243727fda591981cce72b862215","comparison":"d50d1bf7d55b304e603cb5e4438cbcbd904f8507...2c410b05a27f110e70034940d1f269f1c0fe3b9f","deletions":1,"file_count":4,"files":["project/ticket-133/README.md","project/ticket-133/intent.json","src/monag/resume.py","tests/test_resume.py"],"head_sha":"2c410b05a27f110e70034940d1f269f1c0fe3b9f","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":2,"scope":4,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":71,"within_budget":false},"impact":{"components":["claude.com","planfile","project","semcod","src/monag","tests"],"files":["claude.com/claude-code","planfile/core/decompose.py","project/governance-check.sh","project/ticket-133/README.md","project/ticket-133/intent.json","semcod/goal","semcod/goal/planfile.yaml","src/monag/resume.py","tests/test_resume.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":11,"name":"Implement claude.com","scope":["claude.com"]},{"estimated_minutes":11,"name":"Implement planfile","scope":["planfile"]},{"estimated_minutes":11,"name":"Implement project","scope":["project"]},{"estimated_minutes":11,"name":"Implement semcod","scope":["semcod"]},{"estimated_minutes":11,"name":"Implement src/monag","scope":["src/monag"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-133"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-133: fix(ticket-133): read a Planfile task without status as open</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,30 105,51 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 71m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-133-6390
TICKET ticket-133
HEAD_SHA 2c410b05a27f110e70034940d1f269f1c0fe3b9f
CORRELATION_ID local-semcod-monag-pr-158-ticket-133
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","governance / enforce=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","governance / remote lifecycle","governance / enforce"]
INPUT required_checks_source = "protected registry (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"semcod/monag","pull_request":158,"head_sha":"2c410b05a27f110e70034940d1f269f1c0fe3b9f","base_sha":"d50d1bf7d55b304e603cb5e4438cbcbd904f8507","diff_sha256":"dee8be1957870395cd930c7d015e10ac0f2df12ee73abc99fc2c55c047e5e3ea"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":false,"critical_paths":[],"observed_paths":["project/ticket-133/README.md","project/ticket-133/intent.json","src/monag/resume.py","tests/test_resume.py"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"not_required","reason":null,"review_sha256":null,"unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"d50d1bf7d55b304e603cb5e4438cbcbd904f8507","head_sha":"2c410b05a27f110e70034940d1f269f1c0fe3b9f","change_digest":"5fbc903022031e494807ee0ff2f15358eea3b243727fda591981cce72b862215","score":60,"complexity":"L","estimated_minutes":71,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "openai/cursor-auto"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit bbc3c34 into main Oct 28, 2026
3 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/133-read-planfile-task-without-status-as-open branch October 28, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant