Skip to content

dcerpc: fragment vt_trailer and frag_len properly - #5161

Merged
gpotter2 merged 2 commits into
secdev:masterfrom
gpotter2:fragfix
Sep 10, 2026
Merged

dcerpc: fragment vt_trailer and frag_len properly#5161
gpotter2 merged 2 commits into
secdev:masterfrom
gpotter2:fragfix

Conversation

@gpotter2

Copy link
Copy Markdown
Member
  • vt_trailer should only be present in the last fragment when fragmenting
  • frag_len is miscalculated in fragments. this is an issue with header signing enabled

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.82%. Comparing base (1d29984) to head (8e6b3cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
- Coverage   80.85%   80.82%   -0.04%     
==========================================
  Files         390      390              
  Lines       97734    97736       +2     
==========================================
- Hits        79021    78991      -30     
- Misses      18713    18745      +32     
Files with missing lines Coverage Δ
scapy/layers/dcerpc.py 91.32% <100.00%> (+0.71%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread scapy/layers/dcerpc.py Outdated
@gpotter2
gpotter2 merged commit 77d9498 into secdev:master Sep 10, 2026
7 of 9 checks passed
@gpotter2
gpotter2 deleted the fragfix branch September 10, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant