Skip to content

List the events of a chart - #172

Merged
mroloux merged 1 commit into
masterfrom
matti/seats-1872-list-the-events-of-a-chart-in-the-sdks
Oct 28, 2026
Merged

mroloux merged 1 commit into
masterfrom
matti/seats-1872-list-the-events-of-a-chart-in-the-sdks

Conversation

@mroloux

@mroloux mroloux commented Oct 28, 2026

Copy link
Copy Markdown
Member

https://linear.app/seatsio/issue/SEATS-1872/list-the-events-of-a-chart-in-the-sdks

Issue: The API can now list a chart's events, paginated (GET /charts/{chartKey}/events, SEATS-1866), but the SDK can't call it.

Fix: Add client.charts.events(chart_key), which lists a chart's events newest first and pages through them like list events.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 28, 2026 08:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the new chart-events listing method.

No open issues 🎉

What changed in this PR

Adds client.charts.events(chart_key) to expose the chart-events endpoint through the SDK’s existing pagination interface.

Changes:

  • Returns chart events using the shared event parser and pagination helpers.
  • Adds tests for chart filtering, newest-first ordering, and page navigation.
File Description
tests/​charts/​testListEventsOfChart.py Tests event filtering, ordering, and pagination.
seatsio/​charts/​chartsClient.py Adds the events(chart_key) listing method.

Review effort: Balanced

@mroloux
mroloux marked this pull request as ready for review October 28, 2026 09:07
@mroloux
mroloux requested a review from a team as a code owner October 28, 2026 09:07
@mroloux
mroloux merged commit 3e2963e into master Oct 28, 2026
3 checks passed
@mroloux
mroloux requested review from bverbeken and schaloner and removed request for a team October 28, 2026 09:07
@mroloux
mroloux deleted the matti/seats-1872-list-the-events-of-a-chart-in-the-sdks branch October 28, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants