Repository navigation
Conversation
…igurable Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new timeout assignment overrides an existing test's request-level timeout, invalidating its expected exception assertion.
1 open issue
What changed in this PR
This PR increases the client's default read timeout to accommodate requests queued during traffic spikes and adds separate connection-timeout configuration.
Changes:
- Sets defaults to 30 seconds for reads and 10 seconds for connections.
- Adds per-client timeout configuration through fluent
Durationsetters. - Documents timeout behavior and adds a local-server test for configurable read timeouts and no retries.
| File | Description |
|---|---|
src/test/java/seatsio/TimeoutTest.java |
Tests configurable read timeouts and no retries after timeout. |
src/main/java/seatsio/util/UnirestWrapper.java |
Sets timeout defaults and applies per-client values to requests. |
src/main/java/seatsio/SeatsioClient.java |
Exposes fluent connection and read timeout setters. |
README.md |
Documents defaults, configuration, and timeout behavior. |
Review effort: Balanced
| AtomicReference<byte[]> responseBody = new AtomicReference<>(); | ||
| request.header("X-Client-Lib", "Java"); | ||
| request.connectTimeout(connectTimeoutMillis); | ||
| request.socketTimeout(socketTimeoutMillis); |
mroloux
deleted the
matti/seats-1827-seatsio-java-raise-default-timeout-to-30s-10s-connect
branch
October 26, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/seatsio/issue/SEATS-1827
Issue: The default 10s timeout is too short when requests wait in Cloud Run's queue during traffic spikes, so customers see timeouts on requests that would have succeeded.
Fix: The read timeout now defaults to 30s and there is a separate 10s connect timeout. Both can be overridden per client with
connectTimeout(Duration)andsocketTimeout(Duration). Timed-out requests are still not retried.