Repository navigation
Support forSaleMode when creating or updating a workspace - #282
Merged
mroloux merged 1 commit intoOct 22, 2026
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes preserve compatibility and correctly include the optional mode, with no blocking defects identified; integration tests were not executed.
No open issues 🎉
What changed in this PR
Adds optional forSaleMode support to workspace creation and updates in the Java SDK while preserving existing method signatures and behavior when omitted.
Changes:
- Adds
ForSaleModewithRATE_LIMITEDandUNLIMITED_BILLABLEvalues. - Adds create and update overloads that include the mode only when provided.
- Adds integration tests exercising both operations with
UNLIMITED_BILLABLE.
| File | Description |
|---|---|
src/test/java/seatsio/workspaces/UpdateWorkspaceTest.java |
Exercises updating a workspace with a sale mode. |
src/test/java/seatsio/workspaces/CreateWorkspaceTest.java |
Exercises creating a workspace with a sale mode. |
src/main/java/seatsio/workspaces/Workspaces.java |
Adds backward-compatible overloads and optional request serialization. |
src/main/java/seatsio/workspaces/ForSaleMode.java |
Defines the supported sale modes. |
Review effort: Balanced
mroloux
marked this pull request as ready for review
October 22, 2026 13:07
mroloux
requested review from
bverbeken and
schaloner
and removed request for
a team
October 22, 2026 13:07
mroloux
deleted the
matti/seats-1795-support-forsalemode-when-creating-or-updating-a-workspace-in
branch
October 22, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/seatsio/issue/SEATS-1795/support-forsalemode-when-creating-or-updating-a-workspace-in-the-sdks
Issue: The API now accepts an optional
forSaleMode(RATE_LIMITEDorUNLIMITED_BILLABLE) when creating or updating a workspace (SEATS-1785), but the SDK can't send it.Fix: Add an optional
forSaleModeparameter to create and update workspace. Leaving it out keeps the current behaviour.