Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 15 15
Lines 1276 1276
=======================================
Hits 1098 1098
Misses 178 178
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nbinomGLMconstructs the prior curvature as a diagonal matrix, then callsnp.diagon that matrix again when adding it to the likelihood Hessian. The second call extracts a vector, which broadcasts across rows and introduces off-diagonal prior curvature. The resulting inverse Hessian is generally nonsymmetric and does not represent the curvature ofnbinomFn.Add the diagonal matrix directly. This corrects the returned shrinkage covariance and the Hessian supplied to Newton-CG; the default L-BFGS-B objective and gradient are unchanged.
The regression compares the inverse of the returned covariance with central finite differences of the objective for two- and four-coefficient designs, shrinking either the first or last coefficient. All four cases fail before the fix and pass afterward.
Validation: full upstream suite passes (69 tests); Ruff lint, formatting, and mypy pass.