Repository navigation
fix(security): mail password resets to the stored admin address - #1607
Merged
Merged
Conversation
Send reset mail to the address stored on the admin row, update the token by aid, and compare the reset token byte-exact with hash_equals.
rumblefrog
force-pushed
the
fix/password-reset-stored-email
branch
from
October 25, 2026 17:39
f349426 to
bdd4fe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens the password-reset flow.
hash_equals).Mailer::overrideTransportForTests()so tests can assert mail recipients.How Has This Been Tested?
New
AuthTestandlostpassword-toast.spec.tscases. phpstan, PHPUnit, E2E and api-contract were run locally.Types of changes