Repository navigation
Port run_dir binding, log confinement, delivery adopt and check prerequisites - #6
Merged
Merged
Conversation
…quisites
- control.py: {run_dir} placeholder bound per check by verify(); checks using
it are never reused (run_directory_outputs_not_reusable).
- delivery.py: confine verification logs to artifacts/sstack/<run>/<file>,
refusing absolute, parent, symlinked-root, out-of-run and hard-linked logs;
the gate binds {run_dir} from each check's own log. Add Store.adopt and the
adopt subcommand for a PR merged at the reviewed head before begin.
- registry.py: optional min_python and requires custom-check fields, strictly
validated and reported as readiness reasons by doctor and verify.
- Docs and ported/new tests for each.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HSV4zUy6rF1vgHFSyUmuva
test_absent_suites pins the built-in suites, and the default-registry test skips when the installed projects.json is not SStack's own. Document the check log placement the gate now requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSV4zUy6rF1vgHFSyUmuva
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ports generic features from the monorepo's older Kizen Stack, so that the monorepo can move to SStack without losing behaviour.
{run_dir}placeholder: a custom check's command can write outputs into its own run directory. Reuse is refused withrun_directory_outputs_not_reusable.artifacts/sstack/<run>/. The gate refuses symlinks, hard links,..and linked artifact roots, and binds{run_dir}from each check's own log before comparing commands.delivery adopt: records a PR that was merged outside the controller for amerge_readypacket. It needsallow_merge, the remote head and base, and a merged state with a merge SHA.min_python(for example"3.12") andrequires(paths relative to the check's cwd, confined to the repo).doctor, byverifyblocking and by the reuse readiness check, with reasonspython_M_m_requiredandrequired_path_missing:<path>.projects.jsonis customized. Previously two tests assumed SStack's own registry and failed after install.Verification
verify changed --base origin/main --jobs 2passed (docs, stack and stack-lint).delivery.py, which shows they detect the missing behaviour.solutions-project-monorepowith its customized registry: the stack suite and all product suites passed there.Review
One independent review found nothing blocking. Optional findings are left as follow-ups:
O_NOFOLLOWrather than read by path again.requirespaths could be re-confined at run time.projects.jsonis parsed again for every check.The README gap it found on log placement is fixed here.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HSV4zUy6rF1vgHFSyUmuva
Generated by Claude Code