Bump trezor to 0.20.2 and add Ledger/Trezor e2e tests - #670
Draft
Uxío (Uxio0) wants to merge 1 commit into
Draft
Uxío (Uxio0) wants to merge 1 commit into
Uxío (Uxio0) wants to merge 1 commit into
Conversation
- Port TrezorWallet to trezorlib 0.20 sessions and callbacks - Show full EIP-712 typed data on Trezor Model T and newer - Add Ledger and Trezor e2e tests with testcontainers - Run Ledger e2e in CI
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 2, 2026
Closed
Uxío (Uxio0)
marked this pull request as draft
October 2, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #594. That Dependabot PR only bumped the pin, but trezorlib 0.20 removes
ClickUIand moves to sessions, soTrezorWalletstopped working with it.Closes #594
Changes
trezorto 0.20.2.requirements.txtfrom Bump trezor from 0.13.10 to 0.20.0 #594 is gone (main uses uv now),uv.lockis updated.TrezorWalletto trezorlib 0.20:HardwareWalletException(passphrase, busy device, any otherTrezorException), so the CLI does not exit with a traceback.HwWallet.sign_typed_data: default signs the hashes. The manager calls it, so Ledger works the same as before.tests/e2e, with testcontainers (images pinned by digest):-m e2e): list accounts, load the device as owner and sender, sign and executesend_ether, sign a Safe message, check the hashes the device showed.-m e2e_trezor): same flow, passphrase on the device, checks the SafeTx fields and message hash screens.-m e2e_trezor): same flow, PIN and passphrase on the host, hash signing.e2eCI job for the Ledger tests, with the Ledger app binary cached.Known limit
THP pairing credentials are not stored, so new models (Safe 7) ask for the pairing code on every start.
Testing
pytest -m "e2e or e2e_trezor": 3 passed locally.