refactor(host): migrate compatibility frontends - #1
Merged
Merged
Conversation
Replace the sibling path dependency with a full git rev pin so CI and local builds resolve pd-vm, pd-host-function, and pd-host-schema from b1d6cffede77f49410bf63525f30b9a46b02dc01.
Update Lua Call construction for the frozen arity, emit qualified file-module namespace calls, and rewrite JS file-module alias.member() calls into implicit externs the shared parser can lower.
Stage complex examples against a stub stdlib, unwrap SourceWithMap diagnostics, drop the sibling rustscript checkout from CI now that pd-vm is git-pinned, and rewrite git deps on crates.io publish.
Lower imported file-module member calls to alias::member in frontend IR instead of flattening them to unqualified implicit externs or probing the bare member first. Local objects, tables, builtins, and shadowed aliases stay as member access.
Replace the synthetic strings stub with the exact b1d6cff strings.rss fixture, run the four examples through the real mapped runner, keep SourceWithMap spans on rejection, and rewrite pd-vm/pd-host-function git deps to crates.io 0.1.0.
Parse original JS, fold only frozen-rewound file-module callees at original offsets, then rewrite Call IR and the semantic index to alias::member while keeping original callee spans. Mark Lua file-module qualified calls as implicit externs so unknown members report the qualified symbol on the call-site line. Guard README 0.1.0 pins.
Assign collision-free same-length placeholders before parse, reject multiline callees that would move line mapping, and rewrite only the span-matched implicit externs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge the independently implemented and reviewed host-descriptor/resource-effects migration candidate into the repository default branch.
Verification
Merge method must remain merge commit so frozen dependency SHAs stay reachable from the default branch.