Repository navigation
Cleanup ssh client connections on copy fails - #191
Open
sideshowcecil wants to merge 3 commits into
Open
sideshowcecil wants to merge 3 commits into
sideshowcecil wants to merge 3 commits into
Conversation
Ensure that client connections during SCP operations are cleaned up correctly. Thus preventing a possible memory leak when connections are not closed
sideshowcecil
requested review from
a team
and
a balanced review from Copilot
October 29, 2026 14:27
There was a problem hiding this comment.
🟡 Changes recommended
Multi-file copies fail because the returned client is never assigned, and cleanup exceptions can mask the original connection or transfer failure.
2 open issues
What changed in this PR
This PR aims to prevent SSH connection leaks when SCP operations fail in the SSHJ file copier plugin.
Changes:
- Moves client creation and connection into the guarded transfer block.
- Moves disconnect and close operations into null-checked
finallyblocks for single-file and multi-file copies.
| File | Description |
|---|---|
src/main/java/com/plugin/sshjplugin/SSHJFileCopierPlugin.java |
Restructures SSH client cleanup to run after failed connections or transfers. |
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Regression tests are missing for connection/authentication failures in both copy methods, including cleanup attempts and preservation of the original cause when cleanup throws an IOException.
1 open issue
2 resolved since last review
Review effort: Balanced
Comment on lines
+188
to
+189
| client = createSshClient(); | ||
| scp.connect(client); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that client connections during SCP operations are cleaned up correctly. Thus preventing a possible memory leak when connections are not closed