Repository navigation
refactor(lore-0141): move the settle reasons into their own file [structure only] - #183
Merged
Merged
Conversation
settle.ts is past 1,400 lines and every new settle code grew it. The reason table (SETTLE_REASONS, UNSENT_REASONS, UNSENT, NOT_SIGN_AGAIN) moves verbatim to reasons.ts; importers point there. No behaviour change. Co-Authored-By: Claude <209825114+claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settle.tsholds over 1,400 lines, and every new/settlecode made it grow. This moves the reasontable to its own file, before task 0141 adds a code to it (#182 stacks on this).
Importers of
SETTLE_REASONS(3 source files, 8 test files) now import it fromreasons.ts.UNSENTandNOT_SIGN_AGAINgainexport, sincesettle.tsreads them from the new file.Evidence
Lines added that were not moved (move purity check, whitespace-insensitive):
1012 passed | 3 skipped, no test assertion changed; typecheck,lint and format clean.
Merge Danger
Door: two-way
Blast Radius: none
🤖 Generated with Claude Code