Skip to content

docs(lore-0344,lore-0345,lore-0346,lore-0347): backlog monitoring review findings - #420

Open
stkrolikiewicz wants to merge 1 commit into
developfrom
docs/0344_monitoring-review-backlog
Open

stkrolikiewicz wants to merge 1 commit into
developfrom
docs/0344_monitoring-review-backlog

Conversation

@stkrolikiewicz

Copy link
Copy Markdown
Collaborator

Backlog tasks from the 2026-11-13 read-only review of CloudWatch metrics and alarms in the shared account (eu-central-1). Docs only: no code, no infra. Infra changes are agreed with the other teams on the account before they ship.

Protection gaps

  • 0344: no alarm reads CoarseSweepTableFailures, and a table that errors still returns Ok from the sweep (repair.rs:685-694, coarse-sweep-worker/src/main.rs:160-187). The runbook says to alarm on it.
  • 0345: two Comet pools that are not in STATIC_POOLS have dropped trades since 2026-11-10 14:17 UTC. This is the third time in five weeks, after 0334 and 0337. The task also covers:
    • ledger-processor-unregistered-pool's shape: an ALARM/OK pair per dropped trade, 61 + 62 messages in 30 days;
    • six unclassified swap emitters behind coverage-sweep-unclassified, in ALARM since 2026-11-09. They are not these pools.
  • 0093 (existing): ticks "confirm the deployed state" with today's describe-alarms output. sdex-push-freshness has had no datapoint since 2026-07-27.

Fewer pages and metrics

  • 0346: remove ledger-processor-no-invocations, which fired after rollup-freshness-1m in 4 of 4 stalls. Also remove oracle-no-invocations (dark-feed covers it) and mtls-notafter-probe-duration-near-timeout (-errors pages a hang a day earlier). cleanup-errors was considered and rejected, with the reason recorded.
  • 0347: stop publishing 15 metric series that nothing reads or that duplicate AWS/Lambda. Trim prices-production-overview from 59 metrics to at most 50.

Checked

  • Every file:line reference is from origin/develop 6672466. The review had read master, which is 165 commits behind.
  • CloudWatch was read with soroban-readonly, using list/describe/get calls only: alarm definitions and history, metric statistics, dashboards, and the ledger-processor and coverage-sweep Lambda logs.
  • The frontmatter of all five files parses as YAML.

…iew findings

Record the verified findings of the 2026-11-13 read-only CloudWatch review
of the shared account, each re-checked against origin/develop and live
CloudWatch:

- 0344: CoarseSweepTableFailures has no alarm, and a failed table still
  returns Ok.
- 0345: two new Comet pools have dropped trades since 2026-11-10; the
  unregistered-pool alarm has the wrong shape; six unclassified sweep
  emitters are untracked.
- 0346: remove three alarms that a kept alarm always beats.
- 0347: stop publishing 15 unread or duplicate metric series and trim the
  overview dashboard to 50 metrics.
- 0093: confirm the deployed push-freshness state; sdex has had no
  datapoint since 2026-07-27.

No code or infra changes; infra work is agreed with the other teams first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant