Repository navigation
fix(driver): don't launch a browser to reset or quit when none has started - #356
Open
andrewfader wants to merge 1 commit into
Open
andrewfader wants to merge 1 commit into
andrewfader wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver#reset!andDriver#quitboth go throughbrowser, which launches Chrome if no browser exists yet. When the launch for a test fails, for example withFerrum::ProcessTimeoutErroron an overloaded CI box, Capybara'sreset!after the test launches Chrome again and waits another fullprocess_timeout, only so it can reset a browser that never ran a page.quitdoes the same: on a driver that never started a browser, it starts one just to close it.We hit this in CI: one slow launch turned into several timeouts in a row during teardown, which pushed the example past our job's deadline.
The fix is that
reset!returns early when no browser has started, andquitcloses the browser only if one exists. The nextvisitstill launches a browser as before, so a launch that fails once is still retried on the next test.Tests: two examples in
spec/lib/driver_spec.rbthat stubBrowser.newto raiseProcessTimeoutError. Without the change both fail (expected no Exception, got #<Ferrum::ProcessTimeoutError ...>); with it both pass. RuboCop is clean.