Repository navigation
ref(page): handle :js_errors in Cuprite instead of passing it to Ferrum - #354
Merged
Merged
Conversation
Ferrum deprecates :js_errors, so Cuprite keeps it out of Ferrum's options and subscribes to Runtime.exceptionThrown on its own pages. The setting is stored as raise_on_js_errors so Ferrum 0.20, which still reads js_errors, doesn't subscribe a second time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ferrum deprecates
:js_errorsin rubycdp/ferrum#688, since raising a page's JavaScript exception into the main thread is a test runner's policy. Cuprite now owns the option: it keeps:js_errorsout of Ferrum's options and subscribes toRuntime.exceptionThrownon its own pages. Behavior for users is unchanged.The setting is stored as
raise_on_js_errorsrather thanjs_errors, because Ferrum 0.20 still readsoptions.js_errorsand would otherwise subscribe a second time and raise every error twice.