Repository navigation
ref(driver): read the window's url and title instead of Ferrum's current_url and current_title - #353
Merged
Merged
Conversation
…ent_url and current_title Ferrum 0.21 deprecates current_url and current_title (rubycdp/ferrum#687). Driver#current_url and Driver#title read the main frame's url and title, which work with Ferrum 0.20.1 too, and the page no longer delegates current_url and current_title to the frame Capybara is switched to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ferrum 0.21 deprecates
current_urlandcurrent_titlein favor ofurlandtitle(rubycdp/ferrum#687), so Cuprite stops using them:Driver#current_urlandDriver#titleread the window'surlandtitle, which Ferrum 0.20.1 already has, so no Ferrum bump is neededCuprite::Pageno longer delegatescurrent_urlandcurrent_titleto the frame Capybara is switched to, and drops itstitleoverrideResults are the same as before, including within a frame.