Add specs for the Fiber scheduler's io_wait hook - #1395
Open
sampokuokkanen wants to merge 1 commit into
Open
Conversation
LoggingScheduler already records io_wait, but only Kernel#sleep and the Fiber specs used it, so nothing checked that IO#wait, #wait_readable and #wait_writable reach the hook at all, nor what events mask and timeout they hand it.
sampokuokkanen
added a commit
to sampokuokkanen/jruby
that referenced
this pull request
Sep 9, 2026
The three IO#wait spec files were identical to ruby/spec's, so this is only what is proposed upstream: the "with a Fiber scheduler" contexts from ruby/spec#1395 and the events mask example from ruby/spec#1396. They sit here until the next full sync picks them up. Upstream: ruby/spec#1395 Upstream: ruby/spec#1396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoggingScheduler already records io_wait, but only Kernel#sleep and the Fiber specs used it, so nothing checked that IO#wait, #wait_readable and #wait_writable reach the hook at all, nor what events mask and timeout they hand it.
Should the specs here be under
core/io/though?IO#waitis in core now.