CI: Cache compiled AWS-LC by resolving the latest stable version - #1108
CI: Cache compiled AWS-LC by resolving the latest stable version#1108junaruga wants to merge 1 commit into
Conversation
Resolve the AWS-LC latest stable version tag before the cache step using `git ls-remote`, enabling the cache to use a version-specific key (e.g., aws-lc-5.8.0). Run `git clone` with the resolved AWS-LC stable version. Assisted-by: Claude:Opus 4.6
|
I don't really want to have to think about AWS-LC's tag naming rules. Should we just stop disabling the cache for AWS-LC and OpenSSL master builds? CI may use an outdated version for up to a week old (IIRC), but I think that may be acceptable. |
You remember the cache enabled term correctly. I found the following text in actions/cache repository. https://github.com/actions/cache#cache-limits
OK. Let me try on the way "stop disabling the cache for AWS-LC and OpenSSL master builds". As the implementation is quite different from this PR, I will open a new PR closing this PR. |
I sent the PR #1109. |
When I was checking ruby/openssl's CI AWS-LC case related to the ruby/rubygems PR ruby/rubygems#9853 (comment) to support AWS-LC in ruby/rubygems, I noticed that we can cache the compiled AWS-LC in ruby/openssl's CI. So, this PR caches the compiled AWS-LC. The
steps.resolve-aws-lc.outputs.versionis such asaws-lc-5.8.0which aligns with the current pattern such asopenssl-4.0.1andlibressl-4.3.2.I tested in my fork repository. The
steps.resolve-aws-lc.outputs.versionisaws-lc-5.8.0, which is the same with the actual latest version released at https://github.com/aws/aws-lc/releases. And I confirmed theaws-lc-5.8.0was used as part of the cache key, and also was used forgit clone -b $AWS_LC_RELEASE. The log is below.https://github.com/junaruga/ruby-openssl/actions/runs/34117715124/job/101728312189#step:4:4
Commit message
CI: Cache compiled AWS-LC by resolving the latest stable version
Resolve the AWS-LC latest stable version tag before the cache step using
git ls-remote, enabling the cache to use a version-specific key (e.g., aws-lc-5.8.0).Run
git clonewith the resolved AWS-LC stable version.Assisted-by: Claude:Opus 4.6