Repository navigation
Conversation
When a signal interrupts select(), pselect6 or ppoll, the kernel writes the remaining time to the timeout argument, and a restart waits only for that time. rr gave them scratch memory for it and didn't copy it back then, so their timeouts started over after every signal without a handler, and after EINTR the program found its original timeout. Copy it back at the interruption, as for sleeps. The kernel doesn't write the remaining time of a TIMER_ABSTIME sleep, so don't give it scratch memory, which rr copied over that argument when a signal interrupted the sleep. Test: intr_remaining_time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keno
force-pushed
the
interrupted-wait-remaining-time
branch
from
October 28, 2026 05:11
dbd40b9 to
ff93f50
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Encountered, debugged, test, patch by AI]
When a signal interrupts select(), pselect6 or ppoll, the kernel writes the remaining time to the timeout argument, and a restart waits only for that time. rr gave them scratch memory for it and didn't copy it back then, so their timeouts started over after every signal without a handler, and after EINTR the program found its original timeout. Copy it back at the interruption, as for sleeps.
The kernel doesn't write the remaining time of a TIMER_ABSTIME sleep, so don't give it scratch memory, which rr copied over that argument when a signal interrupted the sleep.
Test: intr_remaining_time.