Repository navigation
Don't resume a task killed while we prepare its exit() - #4139
Merged
Merged
Conversation
A SIGKILL while rr prepared a task's exit(), blocking its signals and unmapping its buffers, made rr resume the task out of its PTRACE_EVENT_EXIT stop, after which recording failed. Don't restart the exit once the task has died, and don't resume a task that died in rec_prepare_syscall(). The new kill point RRCALL_KILL_IN_EXIT_PREPARATION lets tests send that SIGKILL. Test: exit_killed_during_preparation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AI Split of #4136, part 3]
A SIGKILL while rr prepared a task's exit(), blocking its signals and unmapping its buffers, made rr resume the task out of its PTRACE_EVENT_EXIT stop, after which recording failed. Don't restart the exit once the task has died, and don't resume a task that died in rec_prepare_syscall(). The new kill point
RRCALL_KILL_IN_EXIT_PREPARATION lets tests send that SIGKILL.
Test: exit_killed_during_preparation