Repository navigation
Don't replay a clone() whose task was killed at its entry - #4138
Merged
Merged
Conversation
When a task died at the entry of a syscall before rr saw the entry, e.g. because a seccomp filter killed it, handle_ptrace_exit_event() recorded a made-up syscall-entry event, and for a clone() replay then tried to create the new task and failed with "Unable to find TraceTaskEvent; trace is corrupt". Mark such events failed_during_preparation: rr lets a clone() go ahead only from its syscall-entry stop, in prepare_clone(), so such a clone() created no task. Test: seccomp_kill_clone Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AI Split of #4136, part 2]
When a task died at the entry of a syscall before rr saw the entry, e.g. because a seccomp filter killed it, handle_ptrace_exit_event() recorded a made-up syscall-entry event, and for a clone() replay then tried to create the new task and failed with "Unable to find TraceTaskEvent; trace is corrupt". Mark such events failed_during_preparation: rr lets a clone() go ahead only from its syscall-entry stop, in prepare_clone(), so such a clone() created no task.
Test: seccomp_kill_clone