Skip to content

docs(release): W4.3 release notes and running-guide roll-up (W4-R3) - #1014

Merged
rootwarp merged 2 commits into
developfrom
docs/w4-r3-872
Nov 19, 2026
Merged

rootwarp merged 2 commits into
developfrom
docs/w4-r3-872

Conversation

@rootwarp

@rootwarp rootwarp commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

This PR collects the W4.3 release notes. It copies the ## Release note section of each of the 13 W4.3 source PRs into docs/releases/UNRELEASED.md, word for word. It adds the migration steps.

Closes #872
Refs #651
Refs #819

  • Base: develop @ 920a7afacce843426a54f719a198c5bc886a07e4.
  • Head: 49d4cacdafe597490dd736da466eda660722c57a (commit 1 7963180b, fix1 commit 49d4cacd).
  • Files: docs/releases/UNRELEASED.md only. docs/running-guide.md does not change. The source PRs require no changes to the running guide.

Sources

These are the 13 PRs that the #872 header lists.

Plan ID Issue PR Merge SHA ## Release note ## Running-guide delta
W4-E5 #861 #959 90d7a2a33a0c50e0865d44c2fdc9f16e09227f4d yes "none"
W4-E7a #862 #967 dc7760289a531c63480f2c62031a9f9c6950c429 yes "none"
W4-E2b #851 #969 f65ce003778ea1f6e110f201e356eca4dbfc5109 yes "none"
W4-E7b #863 #973 d421f4cbd4ef98b8674f5f298f14fe1b8a46322d yes "none"
W4-E2c #852 #972 6a748049ba46162b6a555d7e70dba437dd0bc479 yes "none"
W4-E3a #854 #978 3492a7824ea9a5e374fceb5e0f21301ca6ecfce7 yes no section
W4-E7d #866 #986 44031da49f8eba3679371565b01edd06b6740680 yes no section
W4-E3b #855 #982 c197dabb3544d2106565f65ff827aae042dcd389 yes no section
W4-E3c #856 #988 4d7cb549977f6ec7299935eaf87cae3ce22bd01a yes no section
W4-D4a #869 #997 2ca52a2a231f6dd73994f2087610947b7eca4a64 yes no section
W4-D4b #870 #1003 e7c89850e5c8e2e8e6ad65e61a7239a8c74dda8d yes no section
W4-D4c #871 #1004 b412d6482dced980eacb6304f80e2070f870ec8d yes no section
W4-E4c #859 #994 a386f2db55de8662933f1102db906dc62669e12e yes no section

Placement in docs/releases/UNRELEASED.md:

  • 12 notes are new sections at the end of the file. Each heading is the title of the issue without the plan-ID prefix.
  • The W4-E4c note has two replacement texts. Text 1 replaces the section "Startup proposer preparation ends when the orchestrator returns" in place. Text 2 replaces the paragraph that started "prepare_beacon_proposer and register_validator run on their own task from" in place.
  • The new section "W4.3 migration: changes and steps for operators" is the last section.

W4.3 PRs that are not sources (#872 does not list them):

Plan ID PR Release note in the PR body Result
W4-E1 #960 none Not copied
W4-E2a #966 none Not copied
W4-E2d #976 none (shutdown returns to the baseline) Not copied
W4-E7c1 #975 none (the W4-E7b note covers it) Not copied
W4-E7c2 #984 none (the W4-E7b note covers it) Not copied
W4-E9a #989 no section; #867 routes the note to W4-E9b and W4-R4 Not copied
W4-T1 #996 None (CI only) Not copied
W4-E4a #991 none (tests only) Not copied
W4-E4b #992 none (the W4-E4c note covers it) Not copied
W4-E4d #995 none (tests only) Not copied
W4-E7e #1000 yes, but #873 routes it to W4-R4 Not copied

Grep list

Each row shows a search string and the number of matching lines in docs/releases/UNRELEASED.md at the head (grep -cF). The first 17 strings come from the release-note AC of the source issues. The next 2 strings must have zero matches. The last 4 strings show the fix1 corrections.

Plan ID Search string Matching lines Lines
W4-E5 validator_registration_batch_size 2 1137,1187
W4-E7a index resolver 2 1141,1191
W4-E7a every slot 2 232,1141
W4-E2b first processed slot 1 1145
W4-E7b revoked beacon node 1 1149
W4-E7b cached duties 2 1149,1197
W4-E2c fetches its own duties 1 1153
W4-E3a retries at the next slot 2 1141,1157
W4-E7d validator indices 3 1161,1169,1197
W4-E7d re-checked after a beacon node is revoked 1 1161
W4-E3b did not finish before the epoch ended 2 1165,1190
W4-E3c no validator index yet 1 1169
W4-D4a re-checked after the boot reads 1 1173
W4-D4b under the machine lock 2 1175,1177
W4-D4c logged once per epoch 1 1181
W4-E4c epoch-boundary task 6 184,186,931,1153,1196,1198
W4-E4c default fee recipient 1 188
W4-E4c (absent) run on their own task from 0 none
W4-E4c (absent) Startup proposer preparation ends when the orchestrator returns 0 none
fix1 B1 A value of 0 sends all registrations in one batch 1 1187
fix1 B2 Keep alerts for failed steps 1 1190
fix1 B3 index resolver revalidation failed; indices stay hidden; retrying at the next slot 1 1191
fix1 B4 Each later failed query in that tick epoch logs at DEBUG 1 1192

No source issue requires a change to the running guide. Thus no search string applies to docs/running-guide.md.

Decisions (intentional)

  • One docs PR for the wave. W4-R3 updates the documents after both W4.3 streams finish. This PR is the only W4.3 change to the two files. Thus the two streams do not share a file (Stage 6 B-2).
  • The notes are word for word. The PR copies each release note word for word. It omits the instructions to W4-R3 and the Markdown quote markers. A reviewer can compare each section with its PR body.
  • W4-E4c replaces text at its existing location. The W4-E4c note tells W4-R3 to replace one section and one paragraph. Thus W4-E4c has no new section at the end of the file. Its replacement heading is the heading in its note.
  • The running guide does not change. Five source PR bodies say that the running guide requires no changes. Eight have no running-guide section. The running guide has no epoch-boundary section and no builder-registration section.
  • W4.3 has no breaking change. Project plan §13 marks no W4.3 surface as breaking. The migration steps name each change that can change the relay load, a trace query, or a log alert. One migration item covers the two WARN notes of W4-E3b and W4-E3c.
  • The migration steps do not repeat the 10 s limit. The W4-E5 note gives a 10 s limit, but the current code does not have it (conflict 1 below).
  • The migration heading keeps the word "migration". fix1 uses "W4.3 migration: changes and steps for operators". The W4.1 and W4.2 sections use the same "migration" prefix, and the [W4-R3] W4.3 release notes and running-guide roll-up (docs only, after both streams) #872 AC names the "migration subsection".

Gaps and conflicts

No source PR is without a release note.

Conflicts with the current code at 920a7afacce843426a54f719a198c5bc886a07e4. W4-E6a (W4.4) merged before this PR. This PR copies each note word for word, as #872 requires. Ash keeps these notes as written. W4-R4 (#897) corrects these sentences:

  1. W4-E5 (fix(builder): cache signed registrations, re-send each epoch, apply batch knobs (W4-E5) #959). The note says: "Until W4-E6a, a single registration round is still cut at 10 s." It also gives a limit of about 10,000 builder keys at the defaults. W4-E6a deleted the old registration path (503d943f). The round budget is now BuilderService::registration_step_timeout(): 10 s plus one batch delay for each batch after the first.
  2. W4-E4c (chore(orchestrator): delete the startup future so run is the slot loop again (W4-E4c) #994). The note says: "A batch that the relay refuses still reports success, so the boot epoch does not send it again." On the W4-E6a path, a refused batch is an error (503d943f).
  3. W4-E7d ([W4-E7d] Stamp the index registry and revalidate after revocation #986), minor. The note says: "Proposer preparation is gated by a follow-up change (W4-E7e)." W4-E7e merged in fix(orchestrator): do not prepare proposers with stale indices (W4-E7e) #1000. The sentence is still true. The W4-E7e note goes to W4-R4.
  4. W4-E2b (fix(orchestrator): run the epoch boundary runner on its own Orchestrator-tier task woken by every processed slot, boot epoch included (W4-E2b) #969), minor. The note lists four runner steps. The runner now has more steps (duty fetch, builder registration, proposer preferences). Later notes describe these steps.

Conflicts between the brief and the issue:

  • The brief says "Append one UNRELEASED section for each issue". The W4-E4c note asks for two in-place replacements. This PR follows the note text.
  • The brief and the issue use develop...HEAD. The local develop branch is old (64c8ccb7). The gates use origin/develop...HEAD, and origin/develop is the base.

Fix log

  • fix1 (49d4cacd), for Harper review 5969286908. This commit corrects four migration steps against the code at the base (B1–B4): a batch size of 0, the unfinished-step WARN, the revalidation WARN, and the liveness WARN. It also changes the migration wording (N1–N3). This PR body has new wording (N4) and the self-check (N6). The fix1 commit message has the STE wording for the first commit (N5), because the first commit stays as it is. The copied notes do not change.

Gates

Evidence on the box: /workspace/rvc/run-872/out/fix1/gates.md. All gates ran on the head 49d4cacdafe597490dd736da466eda660722c57a.

Gate Result
cargo nextest run -p rvc-architecture-tests --no-fail-fast (private CARGO_TARGET_DIR, rustc 1.99.0) pass: 409/409, docs_freshness 9/9, gitleaks_allow_scope 1/1
git diff --stat origin/develop...HEAD 1 file: docs/releases/UNRELEASED.md
scripts/gitleaks_range_scan.sh (gitleaks 8.21.2, strict config) on 920a7afa..HEAD pass: 2 commits, no leaks
gitleaks --no-git on docs/releases (strict config) pass: no leaks
Copied-note check (verify.py) pass: the 12 notes and the 2 W4-E4c texts match their PR bodies byte for byte
Repository search for the two replaced texts 0 matches in all tracked files

Self-check (AGENTS.md)

  • Red check: This PR adds no tests. It changes only documentation.
  • Measurement claims: None. This PR makes no performance claim and no "no regression" claim.
  • Repository search: The grep list above records the matches for the required strings. The repository has zero matches for both removed strings.
  • Signing roots: This PR adds or changes no signing-root test and no hash_tree_root test.

Size

git diff --shortstat origin/develop...HEAD: 1 file changed, 73 insertions(+), 7 deletions(-). The diff has 73 added lines and 7 removed lines, for a total of 80 lines. The plan estimate is 140 lines (210 after calibration).

Copy the release note of each W4.3 source PR into
docs/releases/UNRELEASED.md. The text of each note is verbatim. Each
section uses the title of its issue as the heading.

The W4-E4c note replaces the section "Startup proposer preparation ends
when the orchestrator returns". It also replaces the paragraph that
starts "`prepare_beacon_proposer` and `register_validator` run on their
own task from". This commit applies the two replacements in place.

Add the W4.3 migration list. W4.3 has no breaking change. The list names
each behavior change and the operator action.

No source PR has a running-guide delta. Thus docs/running-guide.md does
not change.

Refs #872
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Total: 94.69% (140569 / 148449 lines)

File Coverage Lines
src/bls_to_execution.rs 92.5% 246/266
src/deposit.rs 100.0% 295/295
src/existing_mnemonic.rs 86.3% 120/139
src/exit.rs 94.2% 259/275
src/fs_util.rs 98.5% 64/65
src/main.rs 0.0% 0/51
src/network.rs 100.0% 138/138
src/new_mnemonic.rs 92.7% 460/496
src/password.rs 92.6% 212/229
src/verify.rs 97.6% 82/84
src/main.rs 95.1% 887/933
src/cli.rs 90.2% 542/601
commands/doppelganger.rs 96.7% 327/338
commands/health.rs 100.0% 5/5
commands/prepare_exit.rs 90.1% 182/202
commands/signed_exit.rs 97.5% 1101/1129
commands/slashing.rs 93.5% 144/154
commands/submit_exit.rs 75.3% 73/97
commands/voluntary_exit.rs 63.1% 41/65
src/logging.rs 90.4% 641/709
src/main.rs 100.0% 44/44
bin/generate_architecture_md.rs 0.0% 0/8
src/lib.rs 83.5% 192/230
src/rust_source.rs 93.9% 1381/1471
src/admission.rs 86.4% 51/59
src/client.rs 88.3% 1884/2133
src/error.rs 100.0% 57/57
src/http_caps.rs 89.6% 43/48
src/prepare_check.rs 85.0% 306/360
src/retry.rs 100.0% 53/53
src/shape.rs 100.0% 30/30
src/ssz_deser.rs 95.3% 631/662
src/types.rs 95.7% 1882/1967
src/v4_wire.rs 100.0% 87/87
src/error.rs 100.0% 22/22
src/metrics.rs 98.9% 89/90
service/mod.rs 88.4% 1305/1477
src/traits.rs 73.1% 68/93
src/types.rs 100.0% 7/7
src/validation.rs 99.0% 191/193
src/admission.rs 98.5% 194/197
src/broadcast.rs 98.0% 146/149
src/error.rs 100.0% 13/13
src/fan_out.rs 94.8% 2581/2723
src/header_quorum.rs 100.0% 238/238
src/health.rs 86.9% 292/336
src/manager.rs 95.5% 8800/9214
src/metrics.rs 98.4% 186/189
src/mock.rs 93.6% 1132/1210
src/revocation_commit.rs 86.4% 51/59
src/sse.rs 87.3% 1440/1649
sse/frame.rs 98.1% 363/370
src/submit.rs 96.9% 557/575
src/sync_status.rs 98.3% 920/936
src/traits.rs 96.1% 395/411
src/types.rs 99.2% 245/247
src/service.rs 98.9% 2411/2439
src/traits.rs 73.9% 17/23
src/bls.rs 90.2% 220/244
src/composite_signer.rs 92.9% 469/505
src/eip2333.rs 97.1% 233/240
src/error.rs 100.0% 63/63
src/insecure.rs 100.0% 131/131
src/key_manager.rs 94.7% 791/835
src/keystore.rs 98.2% 1471/1498
src/mnemonic.rs 100.0% 91/91
src/signer_trait.rs 97.8% 89/91
src/signing.rs 97.7% 126/129
src/signing_root.rs 98.3% 456/464
src/test_utils.rs 100.0% 41/41
src/typed_signer.rs 94.4% 656/695
src/voluntary_exit_signing.rs 100.0% 129/129
src/enablement.rs 100.0% 26/26
src/epoch_clock.rs 97.7% 84/86
src/forward_window.rs 97.6% 1051/1077
src/lib.rs 100.0% 34/34
src/marker_file.rs 96.3% 129/134
src/restart_skip.rs 100.0% 34/34
src/duty.rs 100.0% 47/47
src/metrics.rs 100.0% 26/26
src/tracker.rs 98.6% 3401/3450
src/aggregation.rs 100.0% 307/307
src/aggregator.rs 96.4% 81/84
src/block.rs 99.4% 831/836
src/block_body.rs 94.3% 1508/1599
src/block_body_json.rs 96.4% 397/412
src/builder.rs 99.0% 96/97
src/builder_request_auth.rs 90.8% 108/119
canonical/gvr_hex.rs 100.0% 25/25
canonical/pubkey_hex.rs 98.4% 63/64
canonical/signing_root_hex.rs 100.0% 13/13
src/deposit.rs 98.2% 161/164
src/domains.rs 100.0% 64/64
src/duties.rs 98.4% 63/64
src/fork.rs 99.3% 435/438
src/hex_fixed.rs 100.0% 108/108
src/lib.rs 96.3% 131/136
src/networks.rs 100.0% 91/91
src/payload_attestation.rs 98.5% 64/65
src/proposer_preferences.rs 86.4% 19/22
src/serde_signature.rs 97.1% 68/70
src/signed_block_contents_json.rs 100.0% 154/154
src/ssz_helpers.rs 95.9% 396/413
src/sync_committee.rs 99.0% 307/310
src/tree_hash_utils.rs 93.4% 253/271
src/client.rs 91.0% 998/1097
src/lib.rs 100.0% 212/212
src/auth.rs 95.4% 334/350
src/error.rs 95.2% 258/271
src/handlers.rs 81.6% 678/831
src/lifecycle.rs 93.6% 1552/1658
src/server.rs 84.7% 400/472
src/traits.rs 97.6% 40/41
src/types.rs 96.4% 80/83
src/url_validator.rs 91.5% 193/211
src/definitions.rs 93.7% 177/189
src/lib.rs 95.3% 241/253
src/server.rs 95.3% 306/321
src/hex.rs 100.0% 39/39
src/logging.rs 99.3% 288/290
src/pubkey.rs 100.0% 62/62
src/span_names.rs 100.0% 70/70
src/client.rs 80.5% 124/154
src/wire.rs 95.1% 705/741
src/error.rs 100.0% 6/6
src/lib.rs 100.0% 10/10
src/network.rs 100.0% 43/43
sections/beacon.rs 0.0% 0/12
sections/builder.rs 98.2% 109/111
sections/builder_limits.rs 54.5% 12/22
sections/duties.rs 100.0% 55/55
sections/fork_schedule.rs 79.3% 46/58
sections/grpc_signer.rs 0.0% 0/8
sections/keymanager.rs 95.8% 114/119
sections/keys.rs 0.0% 0/9
sections/logfile.rs 62.5% 15/24
sections/mod.rs 99.3% 139/140
sections/monitoring.rs 46.2% 6/13
sections/network.rs 0.0% 0/8
sections/proposer_config.rs 62.5% 20/32
sections/safety.rs 61.9% 13/21
sections/secret_provider.rs 24.0% 6/25
sections/server.rs 0.0% 0/3
sections/slashing.rs 0.0% 0/6
sections/timing.rs 100.0% 94/94
sections/tracing.rs 61.0% 25/41
containers/attestation.rs 93.9% 123/131
containers/block_body.rs 97.9% 94/96
containers/body_leaves.rs 95.1% 214/225
containers/builder_requests.rs 95.6% 65/68
containers/envelope.rs 95.9% 94/98
containers/execution_payload.rs 94.4% 51/54
containers/leaves.rs 95.9% 162/169
containers/payload.rs 93.6% 103/110
containers/requests.rs 97.8% 44/45
src/kat.rs 100.0% 49/49
src/lib.rs 100.0% 71/71
src/merkle.rs 94.6% 88/93
src/roots.rs 96.5% 390/404
bin/gen_spec_kat.rs 81.3% 1091/1342
src/loader.rs 87.1% 196/225
src/lib.rs 92.0% 150/163
background_tasks/config_url.rs 95.8% 2917/3046
background_tasks/monitoring.rs 93.3% 280/300
src/beacon_adapter.rs 98.0% 484/494
bootstrap/beacon.rs 97.9% 512/523
bootstrap/enablement.rs 98.2% 1222/1244
bootstrap/executor.rs 95.6% 739/773
bootstrap/keys.rs 78.4% 333/425
bootstrap/mod.rs 100.0% 60/60
bootstrap/run.rs 93.4% 1559/1669
bootstrap/services.rs 97.8% 750/767
bootstrap/signer_probe.rs 90.7% 603/665
bootstrap/slashing.rs 91.1% 205/225
bootstrap/tasks.rs 94.6% 930/983
config/builder.rs 93.2% 2739/2940
config/error.rs 100.0% 136/136
config/network.rs 100.0% 118/118
config/types.rs 96.1% 3753/3906
src/deletion_denylist.rs 92.3% 372/403
src/detection_marker.rs 97.3% 1982/2038
src/detection_stop.rs 98.8% 251/254
src/index_resolver.rs 97.4% 1216/1248
src/key_admission.rs 92.7% 612/660
keymanager_adapters/config.rs 100.0% 86/86
keymanager_adapters/doppelganger.rs 56.5% 78/138
keymanager_adapters/import_window.rs 96.6% 1004/1039
keymanager_adapters/kdf_budget.rs 100.0% 173/173
keymanager_adapters/keystore.rs 82.4% 742/901
keymanager_adapters/notifier.rs 84.0% 21/25
keymanager_adapters/remote_keys.rs 96.3% 105/109
keymanager_adapters/slashing.rs 83.1% 143/172
keymanager_adapters/spawn.rs 91.5% 182/199
keymanager_adapters/validator.rs 52.9% 46/87
keymanager_adapters/voluntary_exit.rs 99.3% 398/401
src/liveness_loop.rs 98.2% 2910/2962
src/metrics.rs 99.6% 242/243
orchestrator/aggregation.rs 92.4% 2341/2534
orchestrator/attestation.rs 85.9% 1209/1407
block_proposal/mod.rs 98.2% 56/57
coordinator/mod.rs 93.7% 947/1011
orchestrator/dispatch.rs 89.8% 150/167
orchestrator/duty_management.rs 98.5% 705/716
orchestrator/epoch_boundary.rs 99.0% 3822/3862
orchestrator/error.rs 100.0% 31/31
orchestrator/head_events.rs 99.4% 334/336
orchestrator/payload_attestation.rs 97.1% 2311/2380
orchestrator/slot_anchor.rs 94.9% 111/117
orchestrator/slot_context.rs 94.7% 1297/1369
orchestrator/sync_committee.rs 94.9% 2311/2436
orchestrator/utils.rs 97.6% 486/498
validation/attestation_data.rs 100.0% 149/149
src/pubkey_index.rs 98.1% 414/422
src/quiesce.rs 98.7% 298/302
src/slashing_monitor.rs 94.3% 280/297
src/startup.rs 97.2% 650/669
src/test_metrics.rs 100.0% 49/49
src/format.rs 82.8% 82/99
src/key_source_manager.rs 96.4% 1363/1414
src/lib.rs 97.6% 82/84
src/metrics.rs 100.0% 74/74
src/refresh.rs 97.7% 1231/1260
src/lib.rs 78.9% 310/393
src/lib.rs 100.0% 20/20
audit/cn.rs 83.6% 127/152
audit/log.rs 63.3% 31/49
audit/mod.rs 100.0% 41/41
backend/basic.rs 93.7% 311/332
backend/signer_adapter.rs 50.0% 6/12
src/config.rs 99.8% 823/825
src/error.rs 56.2% 27/48
src/gate_shared_across_transports.rs 100.0% 97/97
src/grpc_common.rs 99.5% 370/372
grpc_tls/mod.rs 96.7% 118/122
grpc_tls/server_builder.rs 100.0% 12/12
accept_loop/mod.rs 94.4% 117/124
http_api/dispatch.rs 98.9% 366/370
http_api/mod.rs 97.8% 132/135
http_api/pubkey.rs 98.7% 77/78
http_api/request.rs 95.1% 77/81
http_api/response.rs 98.8% 241/244
routes/mod.rs 96.5% 193/200
tls_config/mod.rs 93.8% 61/65
src/insecure_startup.rs 100.0% 65/65
src/metrics.rs 98.5% 658/668
src/reload.rs 78.8% 216/274
server/backend.rs 97.9% 94/96
server/grpc.rs 88.2% 150/170
server/http.rs 90.0% 235/261
server/mod.rs 92.9% 1168/1257
server/slashing.rs 84.9% 225/265
src/service.rs 95.4% 1879/1969
src/sign_plan.rs 98.7% 833/844
slashing/config.rs 97.3% 73/75
src/tls_io.rs 100.0% 11/11
src/trace_ctx.rs 100.0% 41/41
src/core.rs 92.5% 1853/2004
src/error.rs 98.1% 154/157
src/fail_closed.rs 100.0% 3/3
src/gate.rs 92.1% 314/341
src/lib.rs 96.5% 4228/4381
src/locks.rs 85.1% 40/47
src/metrics.rs 92.6% 225/243
service_util/circuit_breaker.rs 100.0% 129/129
src/test_utils.rs 100.0% 112/112
src/traits.rs 75.0% 12/16
src/audit.rs 91.7% 22/24
db/interchange.rs 96.5% 1285/1331
db/migrations.rs 80.6% 412/511
db/mod.rs 98.3% 788/802
db/open.rs 87.9% 326/371
db/records.rs 99.2% 492/496
db/watermarks.rs 97.1% 726/748
src/error.rs 100.0% 7/7
src/evaluate.rs 97.9% 94/96
src/group_commit.rs 89.4% 388/434
src/history.rs 97.9% 466/476
src/metrics.rs 95.7% 90/94
src/reader.rs 76.4% 42/55
src/rules.rs 92.6% 390/421
src/scoped.rs 100.0% 203/203
src/stage.rs 83.4% 267/320
src/types.rs 92.0% 380/413
src/config.rs 100.0% 190/190
src/file_appender.rs 98.3% 119/121
src/format.rs 92.6% 386/417
src/health_probe.rs 97.7% 128/131
src/init.rs 96.1% 370/385
src/propagation.rs 94.1% 256/272
src/rolling.rs 99.4% 330/332
src/shutdown.rs 90.6% 29/32
src/trace_id.rs 98.1% 158/161
src/clock.rs 96.5% 556/576
src/error.rs 100.0% 12/12
src/lib.rs 100.0% 19/19
src/block_selection.rs 100.0% 84/84
src/config.rs 100.0% 15/15
src/error.rs 94.7% 198/209
src/store.rs 97.0% 5647/5823
src/hex_serde.rs 90.2% 46/51
src/lib.rs 97.9% 568/580

@rootwarp rootwarp left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #1014 (W4-R3 / #872) — Harper Formal R1

Overall verdict: REQUEST_CHANGES (4 BLOCKING, 6 NIT). The 13 source notes match their PR bodies word for word. Both W4-E4c in-place replacements are correct and remove only the specified text. The W4.3 migration list has four operator-alert errors. The four stale source notes that W4-E6a left behind are known and deferred to W4-R4 (#897). They are not findings.

  • Head: 7963180bd95955c622e7f9731457a217febfa454 (re-checked at FINAL against gh pr view 1014 and the review worktree; unchanged)
  • Tree: 57ea2086b9352e60dfccf1487c68795830132af0
  • Develop / parent: 920a7afacce843426a54f719a198c5bc886a07e4 — 1 ahead / 0 behind. Live develop stayed at this SHA during the review.
  • Branch docs/w4-r3-872. DRAFT, MERGEABLE, OPEN. One signed commit sits directly on develop. This is the expected R1 shape. It is not a finding. Author = committer = Joonkyo Kim <rootwarp@gmail.com>. The commit has a Good "git" signature. Authored and committed 2026-11-19 13:02:10 KST (Asia/Seoul).

Diff versus the assigned parent: 1 file, docs/releases/UNRELEASED.md, +74/−7. No production code and no Cargo.lock change.

This review used one Codex run: gpt-6.2-sol with model_reasoning_effort=high. The wrapper started at 2026-11-19 13:09:24 KST (Asia/Seoul) and exited 0 at 13:20:34 KST.

BLOCKING

B1 — The batch-size text omits a value of 0

docs/releases/UNRELEASED.md:1187 says the process sends registrations in batches of validator_registration_batch_size. BuilderService::send_batches treats 0 as “send all registrations in one batch.” An operator who set 0 needs that behavior when they check relay load.

Rewrite: “A positive validator_registration_batch_size sets the maximum number of registrations per batch. A value of 0 sends all registrations in one batch. validator_registration_batch_delay sets the delay in milliseconds between batches. The defaults are 500 registrations and 500 ms. Before you upgrade, check both values if you use a value that differs from its default.”

Evidence: crates/builder/src/service.rs:368–395.

B2 — The unfinished-step alert can hide other failures

Line 1190 says a key that waits for activation causes this WARN once per epoch, and “An alert on this WARN must not fail for a key that waits for activation.” The WARN combines all unfinished steps in one record (abandoned_steps and last_outcomes). The same line can also name a failed step. The instruction gives no condition for an alert.

Rewrite: “When the runner starts a later epoch, it logs one WARN if the previous epoch has unfinished steps. Match epoch-boundary steps did not finish before the epoch ended. Check abandoned_steps and last_outcomes. If PrepareProposers is NotReady, check for keys that are pending activation. Keep alerts for failed steps and other unfinished steps.”

Evidence: crates/rvc/src/orchestrator/epoch_boundary.rs:343–357.

B3 — Revalidation uses a different WARN

Line 1191 says index resolver get_validators failed; retrying at the next slot shows each failed get_validators call. After a revocation, revalidate_at logs index resolver revalidation failed; indices stay hidden; retrying at the next slot. An alert that matches only the documented message misses those failures.

Rewrite: “For a failed lookup of unresolved indices, match index resolver get_validators failed; retrying at the next slot. After revocation, match index resolver revalidation failed; indices stay hidden; retrying at the next slot for a failed revalidation. If doppelganger detection is off, a failed startup lookup logs validator index resolution failed at boot; duties stay empty until the index resolver succeeds.”

Evidence: crates/rvc/src/index_resolver.rs:307–314 and :357–378. Boot WARN: crates/rvc/src/bootstrap/enablement.rs:174.

B4 — The liveness WARN is not one line in every epoch

Line 1192 says "liveness query failed" is a WARN one time in each epoch and that an alert that counts this WARN gets one line in each epoch. The code emits a WARN only for the first failed query in a tick epoch. An epoch with no failed query has zero such warnings. Later failures in the same tick epoch are at DEBUG.

Rewrite: “For liveness failures, match the message prefix liveness query failed. The first failed query in each tick epoch logs a WARN. Each subsequent failed query in that tick epoch logs at DEBUG. A tick epoch with no failed query has zero such warnings.”

Evidence: crates/rvc/src/liveness_loop.rs:535–564.

NIT

N1 — Shorten the migration introduction and the WARN list headings

Lines 1183–1189 use “breaking change,” “changes can change,” and one long WARN heading line. The meaning is clear. Concrete rewrites are in pr1014-r1/scratch/harper-logs/ste-recheck.md and in the Codex report.

N2 — Name the operator and the task in the no-action list

Lines 1194–1198 use “No operator action,” “gets its own duties,” and “this time.” The meaning is clear. Concrete rewrites are in the STE record.

N3 — Name the boot epoch check

Line 1200 uses “A doppelganger boot that moves into epoch 1.” The meaning is clear. A concrete rewrite is in the STE record.

N4 — Rewrite the live PR body summary, grep list, decisions, and size text

Words such as “docs-only roll-up,” “running-guide delta,” “verbatim,” and “gross size” have a clear meaning. Concrete rewrites are in the STE record. The grep counts, the decisions, and the size +74/−7 match the pinned diff.

N5 — Rewrite the commit message

“Verbatim,” “applies the two replacements,” and “running-guide delta” have a clear meaning. A concrete rewrite is in the STE record.

N6 — Add the pre-PR self-check to the PR body

AGENTS.md requires the four checklist items in the body. The Gates section already gives some of the evidence. Add the four items and the result for each: no new tests; no measurement claims; the recorded search matches and zero matches for the two removed strings; no new or changed signing-root tests.

Known or deferred (not findings)

Issue #872 requires the source notes word for word. W4-E6a merged first, so four notes do not match the current code. Ash keeps them as written. W4-R4 (#897) corrects them. This review does not block on them:

  • W4-E5, PR #959: the note gives a fixed 10 s limit. The current budget adds one batch delay for each batch after the first.
  • W4-E4c, PR #994: the note says a refused batch returns success. The current path reports an error.
  • W4-E7d, PR #986: the note describes W4-E7e as future work. W4-E7e merged in #1000.
  • W4-E2b, PR #969: the note lists four steps. The runner now has more steps.

Tests and CI

An independent comparison of the 13 live ## Release note sections against docs/releases/UNRELEASED.md found no byte differences in the copied notes. Both W4-E4c replacements from #994 sit at their specified locations and remove only the specified text. Five source PRs declare no change to the running guide. Eight have no running-guide section. docs/running-guide.md is unchanged.

cargo nextest run -p rvc-architecture-tests under rustc 1.99.1 (58cf8f9c3 2026-10-13, commit 58cf8f9c35b355199727627d07ae34a4e2846d67): 409 passed, 0 skipped, exit 0, including docs_freshness 9/9. The shared 1.99.1 rustup path was missing, so Harper used a private official 1.99.1 toolchain and did not change /home/box/.rustup. This review ran no mutants, because the PR changes only documentation.

Same-head CI run 44455857801 is success on 7963180bd95955c622e7f9731457a217febfa454. Harper retrieved the metadata and logs through bash -ic with gh, and rechecked them at FINAL. The Test job reports 7,781 passed, one slow, and ten skipped, in 136.581 s, at 2026-11-19 13:13:01 KST (Asia/Seoul) (job 135330573642). Rustdoc tests: 29 passed, 0 failed, 6 ignored. The Check job runs fmt, workspace Clippy, and cargo deny (job 135330573340). Architecture Gates (job 135330573235), Coverage, Scripts, Secret Scan, Spec Vectors, Trace continuity, and GitGuardian also pass. All nine required checks pass. CI uses rustc 1.100.0. This review does not rerun the full workspace suite or Clippy locally.

Every cargo command used /workspace/rvc/bin/locked-cargo, flock -x /tmp/harper-build.lock, rustc 1.99.1, CARGO_INCREMENTAL=0, PROTOC=/usr/local/bin/protoc, CARGO_BUILD_JOBS=1, and private /tmp/harper-pr1014-r1-target. The review did not use /workspace/rvc/target-shared. The private target is absent after the run. One cargo job ran at a time. Harper waited for the shared lock and left other processes alone. The worktree is clean at the pinned head and tree. No comment, review, push, merge, or source fix was made. Harper verified the pins, the verbatim notes, the four migration defects, the deferred stale notes, the architecture tests, and the CI counts, then wrote this FINAL.

Copies: lead/handoff/pr1014, pr1014-r1/out, /home/box/rvc-review-archive/pr1014. First line <!-- prepared by Harper for Ash -->. Not posted. Did not message Ash.

Correct four operator steps in the W4.3 migration section:

- A batch size of 0 sends all registrations in one batch.
- The unfinished-step WARN can name a failed step. Keep alerts for
  failed steps.
- After a revocation, a failed revalidation logs its own WARN.
- The liveness WARN shows only for the first failed query in a tick
  epoch. Later failures in that epoch log at DEBUG.

This commit also changes the wording of the section for ASD-STE100.

About the first commit (7963180): it copies each source note word for
word. It replaces the old section and paragraph at their existing
locations. It adds the W4.3 migration steps. Existing configurations,
data files, and API clients work with W4.3. The source PRs require no
changes to docs/running-guide.md.

This commit does not change the copied notes.

Refs #872

@rootwarp rootwarp left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #1014 (W4-R3 / #872) — Harper Formal fix1 recheck

Overall verdict: CLEARED. B1 through B4 PASS. N1 through N6 PASS. The reviewed commit message stays, as expected for an additive fix.

  • Head: 49d4cacdafe597490dd736da466eda660722c57a (re-checked at FINAL against gh pr view 1014 and the review worktree; unchanged)
  • Tree: 38b362e7abf21b35c109f58da36097e625f76284
  • Develop / parent: 920a7afacce843426a54f719a198c5bc886a07e4 — 2 ahead / 0 behind. Live develop stayed at this SHA during the recheck.
  • Reviewed R1 head (ancestor): 7963180bd95955c622e7f9731457a217febfa454. That commit did not change. One additive fix commit sits on it. This reviewed-plus-additive fast-forward shape is expected. It is not a finding.
  • Branch docs/w4-r3-872. DRAFT, MERGEABLE, OPEN.

Fix1 diff versus the reviewed head: 1 file, docs/releases/UNRELEASED.md, +12/−13, migration subsection only. Total PR versus develop: +73/−7. The cited production files have no diff against develop.

This recheck used one Codex run: gpt-6.2-sol with model_reasoning_effort=high. The wrapper started at 2026-11-19 13:31:47 KST (Asia/Seoul) and exited 0 at 13:38:39 KST. The recheck covers only R1 findings B1–B4 and N1–N6. It adds no new findings.

Recheck results

B1 — PASS

Line 1187 now says a positive validator_registration_batch_size is the maximum number of registrations per batch, and a value of 0 sends all registrations in one batch. It also gives the delay setting and the defaults of 500 and 500 ms. BuilderService::send_batches uses total_count when registration_batch_size == 0 (crates/builder/src/service.rs:368–385).

B2 — PASS

Line 1190 now says: match epoch-boundary steps did not finish before the epoch ended; check abandoned_steps and last_outcomes; if PrepareProposers is NotReady, check for keys that are pending activation; keep alerts for failed steps and other unfinished steps. That matches warn_unfinished in crates/rvc/src/orchestrator/epoch_boundary.rs:343–357.

B3 — PASS

Line 1191 now names all three messages: index resolver get_validators failed; retrying at the next slot for a failed lookup of unresolved indices; index resolver revalidation failed; indices stay hidden; retrying at the next slot after revocation; and validator index resolution failed at boot; duties stay empty until the index resolver succeeds when doppelganger detection is off. These match index_resolver.rs:307–314 and :357–378, and bootstrap/enablement.rs:148–176.

B4 — PASS

Line 1192 now says to match the prefix liveness query failed. The first failed query in each tick epoch logs a WARN. Later failures in that tick epoch log at DEBUG. A tick epoch with no failed query logs no such WARN. That matches crates/rvc/src/liveness_loop.rs:519–564.

N1 — PASS

The introduction and the trace and WARN instructions use the R1 rewrites. Harper accepts the word “migration” in the heading “W4.3 migration: changes and steps for operators.” The W4.1 and W4.2 headings use the same word, and issue #872 uses “migration subsection” in its acceptance criterion.

N2 — PASS

The no-action list now starts with “Operators do not need to make changes for the items below.” It names the epoch-boundary task, the processed-slot retry, and a usual revalidation interval of one slot.

N3 — PASS

Line 1199 now says: if startup crosses from epoch 0 into epoch 1, rvc keeps the keys in the monitoring window. The liveness loop skips not-live decrements if the epoch changes before it applies the query results.

N4 — PASS

The live PR body uses the R1 wording for the summary, the grep list, the decisions, and the size. It records 73 added lines and 7 removed lines, for a total of 80 lines, which matches the pinned diff versus develop.

N5 — PASS

The fix1 commit message uses the R1 replacement wording and describes the first commit in those terms. The reviewed 7963180b message stays. That is the expected additive lineage. It is not a FAIL.

N6 — PASS

The live PR body includes the four AGENTS.md items with a result for each: no new tests; no measurement claims; zero matches for both removed strings; no new or changed signing-root or hash_tree_root tests.

Tests and CI

This recheck ran no local cargo command, no mutants, and no full workspace suite. Harper compared the migration text with the code on the pinned head and confirmed that those source files match develop.

Same-head CI run 44458464692 is success on 49d4cacdafe597490dd736da466eda660722c57a. Harper retrieved the metadata and logs through bash -ic with gh, and rechecked them at FINAL. The Test job reports 7,781 passed, one slow, and ten skipped, in 212.410 s, at 2026-11-19 13:36:48 KST (Asia/Seoul) (job 135339174308). Rustdoc tests: 29 passed, 0 failed, 6 ignored. The Check job includes workspace Clippy (job 135339174360). Architecture Gates (job 135339174496), Coverage, Scripts, Secret Scan, Spec Vectors, Trace continuity, and GitGuardian also pass. All nine required checks pass. CI uses rustc 1.100.0.

The worktree is clean at the pinned head and tree. No comment, review, push, merge, or source fix was made. Harper verified the pins, the four code comparisons, the STE and self-check items, and the CI counts, then wrote this FINAL.

Copies: lead/handoff/pr1014, pr1014-fix1/out, /home/box/rvc-review-archive/pr1014. First line <!-- prepared by Harper for Ash -->. Not posted. Did not message Ash.

@rootwarp
rootwarp marked this pull request as ready for review November 19, 2026 04:41
@rootwarp
rootwarp merged commit 49d4cac into develop Nov 19, 2026
10 checks passed
@rootwarp
rootwarp deleted the docs/w4-r3-872 branch November 19, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant