Repository navigation
Tardigrade: handle SIGTERM/SIGINT so OnStop runs on shutdown - #29
Merged
Al-Muhandis merged 1 commit intoOct 27, 2026
Merged
Conversation
The default disposition killed the process on the spot: the unit finalizations never ran and TBrookHTTPServer.OnStop (Free -> Destroy -> SetActive(False) -> DoClose) never fired. The signal handler only wakes the main loop via Terminate(0), the rest happens in normal context. Local patch pending an upstream PR.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Tardigrade broker installs handlers for SIGTERM/SIGINT that wake up the main loop (
Terminate(0)), so asystemctl stop(or Ctrl+C) now shuts the application down gracefully instead of being killed on the spot by the default signal disposition.Problem
TApplication.DoRunwaits on a condition variable forever, and nothing ever callsTerminate. On SIGTERM the process dies immediately: the unit finalizations never run, andTBrookHTTPServer.OnStop(reachable viaFree -> Destroy -> SetActive(False) -> DoClose) never fires. As a result, daemons built on the broker have no way to flush state or release resources at shutdown — the callback silently never happens.Changes
BrookTardigradeBroker: on UNIX,Runregisters a one-shot handler for SIGTERM and SIGINT.Application.Terminate(0)(sets the terminated flag and signals the condition variable); everything else — finalizations,OnStop— runs in normal execution context on the way out.Testing
Running in production as part of a Telegram moderation daemon (FPC 3.2.2, Linux x86_64, systemd):
systemctl stopnow exits with status 0 and firesOnStop(verified by the daemon saving its training base during shutdown);{$IFDEF UNIX}-guarded).Thank you for the great library!