Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![replay-soc2[bot]](https://avatars.githubusercontent.com/u/60818315?s=60&v=4){kind=small}
Andarist
force-pushed
the
andarist/record-test-run-examples
branch
from
October 15, 2026 06:29
86e0106 to
888f53e
Compare
markerikson
approved these changes
Oct 15, 2026
logpoints-01 and the Playwright test suite example were recordings of CI test runs, copied over by hand, so they never got re-recorded. The Playwright one was of breakpoints-05, which no longer exists. save-examples.ts gets a test-run target: it runs the example's spec from test-run-examples/ in Replay Chromium against the devtools served at PLAYWRIGHT_TEST_BASE_URL, in a recording directory of its own, and uploads the recording the Replay reporter attached the test metadata to. The main suite ignores those specs. The breakpoints-05 example is replaced by debugger-statements, which rewinds and fast-forwards between the debugger statements of the same example page. Both examples are re-recorded, and the tests built on them re-targeted to the current app: React 19's react-dom-client bundle for the logpoint hit count tests, current source lines and console messages, and the metadata save-examples records. The repaint tests now pick an expect step by its exact title, as getByText matched UnexpectedErrorDetails.
Andarist
force-pushed
the
andarist/record-test-run-examples
branch
from
October 16, 2026 20:40
888f53e to
dbb80a9
Compare
Both are re-recorded on the 2026-10-16 Replay Chromium build against main, which now has the React DevTools 8.0 integration. The tests built on logpoints-01 are re-targeted to the current app: - jump-to-code-02: the side panel's dispatch moved to SidePanel.tsx:62. - react_devtools-02: the component list and the Anonymous, Suspense and Activity counts are the ones the current app's React tree gives with React DevTools 8.0 (the same with the previous logpoints-01 recording). The app's React has a separate Activity fiber, so the <Activity> components are listed, and the comment about the hidden <Suspense> the previous golden's React left out no longer applies. Next 15's SideEffect is a function component now, and its name isn't mapped back from the minified one.
Andarist
force-pushed
the
andarist/record-test-run-examples
branch
from
October 16, 2026 20:55
dbb80a9 to
4b3f5ce
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logpoints-01 and the Playwright test suite example were recordings of CI test runs, copied over by hand, so they never got re-recorded. The Playwright one was of breakpoints-05, which no longer exists.
save-examples.ts gets a test-run target: it runs the example's spec from test-run-examples/ in Replay Chromium against the devtools served at PLAYWRIGHT_TEST_BASE_URL, in a recording directory of its own, and uploads the recording the Replay reporter attached the test metadata to. The main suite ignores those specs. The breakpoints-05 example is replaced by debugger-statements, which rewinds and fast-forwards between the debugger statements of the same example page.
Both examples are re-recorded, and the tests built on them re-targeted to the current app: React 19's react-dom-client bundle for the logpoint hit count tests, current source lines and console messages, and the metadata save-examples records. The repaint tests now pick an expect step by its exact title, as getByText matched UnexpectedErrorDetails.