Repository navigation
Give the Elekloader update CLI tests room to run on loaded CI - #615
Merged
Merged
Conversation
Each case runs the real update CLI, up to 20 s per call, but vitest's
default 5 s test timeout failed the first case on a loaded runner
("Test timed out in 5000ms") and so failed module-contract on PR #577.
The catalogue now assembles from module records, which made the CLI a
little slower and moved this case over the limit.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first case of
elekloader update CLIfailedmodule-contracton #577 withTest timed out in 5000ms. It passed locally in 1.3 s. Each case spawns the real update CLI, which has its own 20 s limit per call, but the test itself used vitest's 5 s default, so a loaded CI runner running 4 workers crossed it.#614 made the CLI do a little more work (it assembles the catalogue from the module records and verifies the served folder), which moved this case over the line. Every module PR that runs the full suite would hit it.
Change
One option on the
describe:{ timeout: 60_000 }, above two 20 s CLI calls. No behaviour or assertion changes.Tested
src/tooling/elekloader-update.test.ts: 11 of 11 pass; lint clean.Test timed out in 5000ms) and the runner's measured 18.9 s for the file.🤖 Generated with Claude Code