Repository navigation
Keep main green: run the catalogue tests on documentation-only PRs - #583
Merged
Merged
Conversation
…ink that broke main #580 changed only Markdown, so its check skipped the test suite. The module-guides test checks that every `sdk/...` path the guides name exists, and the guide named sdk/machines/octatrack/events.json, which has not landed. main has failed `npm run check` since, so every PR that touches code inherited a failure it did not cause. The guide now says the registry will be `events.json` beside compatibility.json instead of naming a path that does not exist. A documentation-only check also runs `src/catalog` (about 15 seconds), where the tests that read Markdown live. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
repeat98
pushed a commit
that referenced
this pull request
Oct 14, 2026
Brings #583: documentation-only checks also run the catalogue tests, and the module guide's registry link. The guide's Events section is rewritten next, now that events.json exists on this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fg4pq2GsTYaZktv9UzetGu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`main` has failed `npm run check` since #580, so every pull request that changes code inherits a failure it did not cause (#573 and #555 both hit it).
Cause. #580 changed only Markdown, so its check skipped the test suite. The module-guides test checks that every `sdk/...` path the guides name exists, and the guide named `sdk/machines/octatrack/events.json`, which has not landed yet.
Fix.
`npm run check -- --base origin/main` passes on this branch.
🤖 Generated with Claude Code