Repository navigation
Fix: the Zoom MIDI link waits until a message's timestamp has passed - #1433
Merged
Merged
Conversation
setTimeout truncates a fractional delay and can fire up to a millisecond early, so a timed send could leave before its time (and the timestamp test failed under CI load). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodeMidiAccessinscripts/zoom-device.ts) waited for a timed message with onesetTimeout(wait). Node truncates a fractional delay and can fire up to a millisecond early, so a message could leave a millisecond or two before its timestamp, which Web MIDI never does. Under CI load,scripts/zoom-device.test.mjs("sends each message at its timestamp") failed twice in a row on Sidechain Compressor 0.2.2: ColdFire units join the DRAM runtime when the set has one (#1175) #1195 for this reason (0.5–0.7 ms early).send()keeps waiting untilperformance.now()has passed the timestamp, rounding each wait up. One line, plus a changelog entry. The test is unchanged.npm run pr:readysays Ready.🤖 Generated with Claude Code