Repository navigation
Fix: the Octatrack package rebuild keeps earlier versions' packages - #1120
Merged
Merged
Conversation
The builder clears public/octatrack-modules before its first write, so a write-mode `octatrack:module-packages` dropped every earlier version's .mwrm that main publishes, and a run that stopped part way left the folder half empty (repeat98#1098). The wrapper now puts back every file the run did not rewrite, on success and on failure; the builder, a base input, is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
npm run octatrack:module-packagesin write mode deleted every earlier version's.mwrmthat main still publishes, such assidechain-compressor/0.1.2-experimental.mwrmandlofi2/0.1.0-experimental.mwrm. The builder clearspublic/octatrack-modulesbefore its first write. A run that stopped part way (a recipe mismatch, a missing tool) also left the folder half empty. I found it while rebinding packages for #1098, where the files had to be restored by hand.What changes
scripts/octatrack-module-packages.pysnapshots the published.mwrmfiles before a write and puts back every one the run did not rewrite, whether the run finished or stopped part way. A file the run writes stays as written.--checkand--prepare-portsare untouched. The builder (module_packages.py), a base input, is unchanged.How I checked
test_a_write_keeps_every_package_it_did_not_rewrite: an older version survives a rebuild, the current version is replaced, and both hold when the run fails part way.00ecaf52), a full write run of the real packager leavesgit statusclean: every package rebuilt identical and every earlier version kept. A run that stopped part way (nonodeon the PATH) also leftpublic/untouched.npm run pr:ready: Ready.Guides
Nothing.
🤖 Generated with Claude Code