Repository navigation
Conversation
|
Thanks, this is a clean fix: an explicit opt-in that leaves every other machine's default stop alone, with the host regression to show it. I'd like to merge it, but #1059 just went in first and regenerated the same base files, so it now conflicts with Could you merge Generated by Claude Code |
|
Thanks for the refresh, the fix itself is ready. One thing before I merge: the last two commits add FRACT's artwork under Generated by Claude Code |
9c47d42 to
a5f812a
Compare
|
Update: this branch now includes current The important distinction is that #926 contains the obsolete FRACT FX2/SPACE effect. The current private FRACT has been reworked as a registered track machine, leaving FX1 and FX2 available for other effects. The old PR therefore no longer represents the implementation we are developing or the interface shown in the new previews. I suggest closing #926 as obsolete, with a link to the eventual current track-machine submission, so it is not mistaken for the current FRACT. That machine integration should be submitted separately against the current SDK once the shared native FLEX support is merged. #1108 does not contain or release the FRACT machine itself. I have also intentionally restored the latest FRACT artwork and added the three emulator screenshots with short captions in |
Superseded by the consolidated source submission #926, at FRACT's author's request. The complete native FLEX fix, its host regressions, generated base artifacts, guide corrections and approved FRACT media are preserved there at
7b529cc16c722839cc12d19d8909dd2da5fbe71b. This branch's head7a57fba3477c78f2590a796549b0f3bdba3fd99cis an ancestor of that submission. Closing this redundant PR leaves one review thread; the fix is retained in #926.The fix adds explicit
MODWERK_MACHINE_NATIVE_FLEXopt-in together with START and a same-image render callback. A source machine consuming the native FLEX reader keeps its voice active across both render halves; stale retriggers, refused STARTs, unpaid sources and ordinary own-render machines retain stop protection. Host regression uses the exact shared voice byte that the registry stops. The machine descriptor remains ABI 1 / 80 bytes and the separate START record remains 16 bytes. No hook index or package-format change is introduced.The earlier proposal to close #926 as obsolete is superseded: #926 now replaces its historical FX2/SPACE tree with the current three-grain source draft and includes this prerequisite in the same submission. No new PR or dependency on another module is proposed. Consolidated source and previews.
#926 is ready for maintainer review. Public FR:1 boot preservation, catalogue/package integration and exact-public hardware/lifecycle qualification remain open before a qualified public release. Private reported sound, three grains, centered SIZE, about 80% displayed CPU and no crackle in a short audition do not qualify the public tree. No device action was performed during consolidation.
Current validation, partial Jev coverage and release limitations are recorded in #926 and the dated checkpoint. The consolidated exact-head CI on
7b529cc1passes, including Windows, module-contract and both source builds: https://github.com/repeat98/modwerk/actions/runs/41776599257. The core logger job was scope-skipped. Firmware, samples, audio, card/NVRAM images and private build outputs are not uploaded.