Repository navigation
Fix: Octatrack base, LFO SETUP's PMTR list names a machine track's own parameters - #1080
Merged
Merged
Conversation
…n parameters (#589) The LFO formatter picked the PLAYBACK page from the PB table by the track's raw machine byte, which a machine module's track keeps at FLEX or STATIC, so FM Synth and Analog BD tracks listed FLEX's names. The table now owns the whole 8-byte lookup at 0x4003bff2 and resolves the page through mw_page first, as mw_resolve_pb does; stock machines and the FX cases take the same table as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…base Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0x4003bff4still handed it FLEX's page. Reported in [synth] Wrong LFO1&2 destination names #589; Tim traced it on FM Synth 0.1.5: scale quantizer on MIDI tracks (the author's 2.13 quantizer) #555, where we agreed the base should own the whole lookup.ot_machinesnow owns the whole 8-byte lookup at0x4003bff2(lea table,%a0; bra 0x4003c054), in place of the 4-byte pointer at0x4003bff4.mw_lfo_pbasksmw_pagefirst, asmw_resolve_pbalready does for the page resolver: a machine with atrack_pagegets its own page. Anything else replays stock's lookup throughmw_pb_table, so stock machines and the FX1/FX2 cases are unchanged.--base-only: onlyrequiredBasemoved).docs/MODULE_UI_CAPTURES.md: without--dsp,ot_emurefuses a package that carries a DSP engine with loader refusal 3.npm run pr:readysays Ready (339 test files). The machine event tests pass, and the base build is stock-free, flash-safe and byte-identical in the browser.SRC / STRT.SYN / TONEandSYN / SAT, Analog BD's page and names.--dsp; fixed indocs/MODULE_UI_CAPTURES.md(Driving ot_emu by hand).🤖 Generated with Claude Code