Skip to content

fix: allow renovate-image to take a full digest-pinned image - #1082

Merged
jamietanna merged 1 commit into
mainfrom
fix/renovate-version
Sep 25, 2026
Merged

jamietanna merged 1 commit into
mainfrom
fix/renovate-version

Conversation

@jamietanna

@jamietanna jamietanna commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

In Renovate 44.82.0 we added support for Renovate to extract
renovate-version and renovate-image inputs from a GitHub Actions
workflow.

However, per 0, this doesn't actually work for digest-pinned images,
because this leads to i.e.

ghcr.io/renovatebot/renovate:44.104.2@sha256:c87b1c55ab98286dad9df0c1d84ebe1fbe2a805a68d48dd7a6d577709bf951a7:44

where the :44 is added, as no renovate-version is set.

To fix this, we can check for a : - denoting an image tag - in the
renovate-image, and prioritise the full image in that case.

Comment thread .github/workflows/build.yml Dismissed
In Renovate 44.82.0 we added support for Renovate to extract
`renovate-version` and `renovate-image` inputs from a GitHub Actions
workflow.

However, per [0], this doesn't actually work for digest-pinned images,
because this leads to i.e.

  ghcr.io/renovatebot/renovate:44.104.2@sha256:c87b1c55ab98286dad9df0c1d84ebe1fbe2a805a68d48dd7a6d577709bf951a7:44

where the `:44` is added, as no `renovate-version` is set.

To fix this, we can check for a `:` - denoting an image tag - in the
`renovate-image`, and prioritise the full image in that case.

[0]: renovatebot/renovate#41809 (reply in thread)
@jamietanna jamietanna changed the title fix: foo??? fix: allow renovate-image to take a full digest-pinned image Sep 25, 2026
@jamietanna
jamietanna requested a review from a team September 25, 2026 14:20
@jamietanna
jamietanna marked this pull request as ready for review September 25, 2026 14:20
@jamietanna
jamietanna merged commit 16deced into main Sep 25, 2026
16 checks passed
@jamietanna
jamietanna deleted the fix/renovate-version branch September 25, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants