Skip to content

[Orm37] Skip existing SortDirection enum references - #546

Merged
samsonasik merged 1 commit into
rectorphp:mainfrom
jlherren:fix/skip-existing-sort-direction
Oct 30, 2026
Merged

samsonasik merged 1 commit into
rectorphp:mainfrom
jlherren:fix/skip-existing-sort-direction

Conversation

@jlherren

Copy link
Copy Markdown
Contributor

It kept suggesting the following change, even though the file had a use SortDirection; line.

-                ->orderBy('e.position', SortDirection::Ascending)
+                ->orderBy('e.position', \SortDirection::Ascending)

@jlherren
jlherren marked this pull request as draft October 30, 2026 09:09
@TomasVotruba

Copy link
Copy Markdown
Member

LGTM

@jlherren
jlherren force-pushed the fix/skip-existing-sort-direction branch from 95cdaf0 to 5f62a22 Compare October 30, 2026 09:10
@jlherren
jlherren marked this pull request as ready for review October 30, 2026 09:11
@jlherren

Copy link
Copy Markdown
Contributor Author

Sorry, I wasn't happy with the naming of the tests, I fixed that now.

@samsonasik
samsonasik merged commit 587d06c into rectorphp:main Oct 30, 2026
8 checks passed
@samsonasik

Copy link
Copy Markdown
Member

Thank you @jlherren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants