Harden URL opening, config file permissions, and SDK version - #31
Merged
Merged
Conversation
- TUI: open result URLs via the `open` package instead of a shell command, and only open http(s) URLs. - Config: write ~/.readwise-cli.json with 0600 permissions and tighten existing files on save. - Pin @modelcontextprotocol/sdk to ^1.26.0 instead of "latest". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openpackage (already used inauth.ts) instead of building a shell command, and only openhttp:/https:URLs.~/.readwise-cli.jsonwith0600permissions, since it holds OAuth tokens and the client secret. Achmodafter writing also tightens files created by older versions.@modelcontextprotocol/sdkfrom"latest"to"^1.26.0", matching the lockfile, so global installs don't pick up arbitrary new versions.Testing
npm testandnpm run buildpass.HOME: a new config file is created as600, and an existing644file becomes600after a save.🤖 Generated with Claude Code