iOS: remove every surplus page spacer layer, not every other one - #18
Merged
artemlitch merged 1 commit intoOct 3, 2026
Merged
Conversation
layoutPageSpacers trims the overlay to the spacer count by iterating sublayers while removing from it. The getter hands out the live array, so each removal shifts the rest down and the loop skips every other layer. A page that sends fewer spacers keeps stale strips. Iterating a copy removes them all. Checked with a standalone program over CALayer: 182 layers trimmed to 4 leave 93 with the live array and 4 with a copy. Not built into the app. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
delcamf
marked this pull request as ready for review
October 2, 2026 22:44
Author
|
piper review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the page sends fewer page spacers than before, stale spacer strips stay on screen.
layoutPageSpacersinapple/RNCWebViewImpl.mtrims the overlay by iteratingsublayerswhile removing layers from it. The getter hands out the live array. Each removal shifts the rest down, and the loop skips every other layer, so about half of the surplus stays.The Bookwise riffle (readwiseio/rekindled#13077) hits this when it leaves its zoomed-out view, and works around it on the page side.
Fix
Iterate a copy of
sublayers. One line.Checks
CALayer: 182 layers trimmed to 4 leave 93 with the live array and 4 with a copy.