fix(android): bump androidx.collection to 1.4.4 to avoid MutableIntObjectMap corruption in SurfaceMountingManager - #58389
Conversation
…ng view registry entries Since react#56646 the Android view registry is a MutableIntObjectMap. androidx.collection 1.4.0 to 1.4.2 corrupt ScatterMap and its primitive variants after remove-heavy sequences; androidx fixed it in 1.4.3 (b/352560465). Apps resolve 1.4.0 or 1.4.2, lose registry entries for live views, and RN then drops mount instructions for them, which can leave stale views on screen. Fixes react#58388 Changelog: [Android] [Fixed] - Bump androidx.collection to 1.4.4 to fix view registry entries getting lost in SurfaceMountingManager
|
Hi @pawicao! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-tools
Bot
added
the
Shared with Meta
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D119149754. |
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
2 participants
Summary:
since #56646 the view registry is a
MutableIntObjectMap;androidx.collection1.4.0 to 1.4.2 corruptScatterMapand its primitive variants after remove-heavy sequences, fixed in 1.4.3 (https://issuetracker.google.com/issues/352560465). Apps resolve 1.4.0 or 1.4.2 and lose registry entries; RN then drops mount instructions and can leave stale views.Fixes #58388.
Changelog:
[ANDROID] [FIXED] - Bump androidx.collection to 1.4.4 to fix view registry entries getting lost in SurfaceMountingManagerTest plan
Reproducer: https://github.com/pawicao/rn-android-view-registry-corruption
Unable to find viewStatesoft exceptions on 45 tags over two 40-round runs on a Pixel 9a, and a stale view left on screen.