Fix Modal staying onscreen when dismissed while presenting a child controller - #58364
Open
lazerg wants to merge 1 commit into
Open
Fix Modal staying onscreen when dismissed while presenting a child controller#58364lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
cipolleschi
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Dismissing a
Modalon iOS/Fabric while it was presenting a child view controller (a system alert, an action sheet, the dev menu) left the modal itself stuck onscreen as an empty sheet.RCTModalHostViewComponentViewdismissed the modal's view controller directly, but UIKit forwardsdismissViewControllerAnimated:calls to the topmost presented child, so only the alert closed while React still thought the modal was gone.Now the dismissal goes through the modal's
presentingViewControllerwhenever it has a presented child, closing the whole stack in one animation.Fixes #58326
Changelog:
[IOS] [FIXED] - Fix Modal staying onscreen when dismissed while presenting a child view controller
Test Plan:
Added
RCTModalHostViewComponentViewTests.mm: dismissing with a presented child redirects throughpresentingViewController, falls back to the modal itself when that's nil, and the no-child path still dismisses directly. Couldn't run against a simulator in this environment (no full Xcode/CocoaPods toolchain available here); traced the issue's repro steps against the new logic by hand.