Skip to content

Fix iOS Metro reload after initial bundle failure #58352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janicduplessis wants to merge 7 commits into
base: main
Choose a base branch
from
+4 −1
Open

Fix iOS Metro reload after initial bundle failure #58352

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59248a4
fix: initialize iOS dev settings before bundle load
janicduplessis Sep 4, 2026
650caec
fix: avoid retaining dev settings during bundle load
janicduplessis Sep 4, 2026
27dcad6
test: isolate bundle failure handling
janicduplessis Sep 4, 2026
c5d4dfd
fix: avoid reload setup after invalidation
janicduplessis Sep 4, 2026
77957ee
test: make invalidation coverage deterministic
janicduplessis Sep 4, 2026
073e56e
refactor: initialize dev settings before bundle request
janicduplessis Sep 5, 2026
68e41a4
Restore the callback constraint in the DevSettings comment
janicduplessis Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,10 @@ - (void)handleBundleLoadingError:(NSError *)error

- (void)_loadJSBundle:(NSURL *)sourceURL
{
// DevSettings is needed by _loadScriptFromSource's callback, so it must be initialized first. Doing it before
// the request, not after a successful load, also lets Metro reload when the initial bundle request fails.
[_turboModuleManager moduleForName:"DevSettings"];

#if RCT_DEV_MENU && __has_include(<React/RCTDevLoadingViewProtocol.h>)
{
id<RCTDevLoadingViewProtocol> loadingView =
Expand Down Expand Up @@ -567,7 +571,6 @@ - (void)_loadJSBundle:(NSURL *)sourceURL
[strongSelf handleBundleLoadingError:error];
return;
}
// DevSettings module is needed by _loadScriptFromSource's callback so prior initialization is required
RCTDevSettings *const devSettings =
(RCTDevSettings *)[strongSelf->_turboModuleManager moduleForName:"DevSettings"];
[strongSelf _loadScriptFromSource:source];
Expand Down
Loading