Type ImageLoader native module headers as a string map (#57740) - #57740
Open
rubennorte wants to merge 7 commits into
Open
Type ImageLoader native module headers as a string map (#57740)#57740rubennorte wants to merge 7 commits into
rubennorte wants to merge 7 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113781106. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
force-pushed
the
export-D113781106
branch
from
July 28, 2026 17:26
7696da8 to
3799268
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 10:56
3799268 to
3b4467b
Compare
meta-codesync
Bot
changed the title
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 13:44
3b4467b to
a18ba0f
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 15:22
a18ba0f to
c00740b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
July 29, 2026 16:46
c00740b to
ae54e4b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 3, 2026 14:43
ae54e4b to
baae298
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 3, 2026 16:30
baae298 to
073300a
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 7, 2026 09:55
073300a to
58715a8
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 7, 2026 10:00
58715a8 to
e8e0436
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 7, 2026 13:04
e8e0436 to
a43a7f9
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 10:02
b311115 to
0d91436
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 10:22
0d91436 to
15d1c9b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 10:28
15d1c9b to
c9bb151
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 10:33
c9bb151 to
7d9cd62
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 11:06
7d9cd62 to
380a8c1
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 11:50
380a8c1 to
2897f34
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
2 times, most recently
from
September 8, 2026 14:49
00c8774 to
a6e4980
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
…t#57726) Summary: Pull Request resolved: react#57726 Upgrade the FlatList/SectionList list components, the networking modules (`XMLHttpRequest`, `FormData`, `RCTNetworking`, `convertRequestBody`), and the UIManager modules from `flow` to `flow strict-local`. Public type signatures are preserved exactly, so no consumers need updating; internal `any` and `Object` usages were replaced with accurate types wherever that did not change a public signature. The `headers` parameters on the `XHRInterceptor` interface keep their original `Object` type behind a scoped `$FlowFixMe[unclear-type]`. Flow types indexers invariantly, so any precise annotation would reject existing interceptor implementations that declare a different value type for the header map. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763786
…57730) Summary: Pull Request resolved: react#57730 Upgrade the remaining ReactNative and Core modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763791
Summary: Pull Request resolved: react#57739 Upgrade `deepDiffer`, `codegenNativeCommands`, `Dimensions`, and `ReactNativeTestTools` from `flow` to `flow strict-local`, preserving both public type signatures and runtime behavior. These modules operate on values of arbitrary shape, so the unavoidable `any` and `Function` usages are marked with scoped `$FlowFixMe[unclear-type]` rather than tightened. `Dimensions.addEventListener` deliberately keeps its original `handler: Function` signature. Flow types object properties invariantly, so any precise payload annotation would reject existing subscribers that annotate the payload with their own object shapes, forcing unrelated call sites to change. The generated API snapshot is therefore unchanged for `Dimensions`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763789
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
Summary: Pull Request resolved: react#57734 Upgrade `processTransform` from `flow` to `flow strict-local`, preserving its public type signature. Mechanical violations were fixed accurately; arbitrary-shape internal values are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763784
Summary: Pull Request resolved: react#57737 Upgrade the remaining assorted modules (Touchable pooling, ActionSheetIOS, Alert, LogBox highlight, Text native component, PushNotificationIOS) from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763783
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
rubennorte
force-pushed
the
export-D113781106
branch
from
September 8, 2026 17:05
a6e4980 to
aea34d2
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57740 `getSizeWithHeaders` on the ImageLoader native modules typed its `headers` parameter as the opaque `UnsafeObject`. HTTP headers are a homogeneous string-to-string map, so type them as `{[key: string]: string}` instead. This is codegen-compatible and emits the same native type (`NSDictionary`/`ReadableMap`/`jsi::Object`), so there is no change to the native interface — it only adds value-type validation on the JavaScript side. Other `UnsafeObject` usages in these specs (e.g. `queryCache`'s result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic. Changelog: [Internal] Reviewed By: javache Differential Revision: D113781106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
getSizeWithHeaderson the ImageLoader native modules typed itsheadersparameter as the opaqueUnsafeObject. HTTP headers are a homogeneous string-to-string map, so type them as{[key: string]: string}instead. This is codegen-compatible and emits the same native type (NSDictionary/ReadableMap/jsi::Object), so there is no change to the native interface — it only adds value-type validation on the JavaScript side.Other
UnsafeObjectusages in these specs (e.g.queryCache's result) are left as-is because their accurate types either differ from the callers' expectations or are genuinely dynamic.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D113781106