Make Settings modules Flow strict-local (#57736) - #57736
Open
rubennorte wants to merge 4 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113763793. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 28, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763793
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D113763793
branch
from
July 28, 2026 17:29
e60b367 to
7ef874d
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
July 29, 2026 10:56
7ef874d to
41ad970
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
July 29, 2026 13:43
41ad970 to
82e4ca3
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
July 29, 2026 15:26
82e4ca3 to
b1b793f
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
July 29, 2026 16:49
b1b793f to
1ef071f
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
2 times, most recently
from
September 3, 2026 16:29
712ed50 to
cd4e4c0
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 3, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 7, 2026 09:54
cd4e4c0 to
0f8cb98
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 7, 2026 10:00
0f8cb98 to
ef295c4
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 7, 2026 16:49
069d6aa to
7e1ee37
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 10:02
7e1ee37 to
d5ca438
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 10:14
d5ca438 to
e7de866
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 10:22
e7de866 to
9017d50
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 10:28
9017d50 to
de8eb7b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 10:34
de8eb7b to
7dbc01e
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
2 times, most recently
from
September 8, 2026 12:26
43b41bd to
affd158
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 14:49
affd158 to
45077f0
Compare
…t#57726) Summary: Pull Request resolved: react#57726 Upgrade the FlatList/SectionList list components, the networking modules (`XMLHttpRequest`, `FormData`, `RCTNetworking`, `convertRequestBody`), and the UIManager modules from `flow` to `flow strict-local`. Public type signatures are preserved exactly, so no consumers need updating; internal `any` and `Object` usages were replaced with accurate types wherever that did not change a public signature. The `headers` parameters on the `XHRInterceptor` interface keep their original `Object` type behind a scoped `$FlowFixMe[unclear-type]`. Flow types indexers invariantly, so any precise annotation would reject existing interceptor implementations that declare a different value type for the header map. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763786
…57730) Summary: Pull Request resolved: react#57730 Upgrade the remaining ReactNative and Core modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763791
Summary: Pull Request resolved: react#57739 Upgrade `deepDiffer`, `codegenNativeCommands`, `Dimensions`, and `ReactNativeTestTools` from `flow` to `flow strict-local`, preserving both public type signatures and runtime behavior. These modules operate on values of arbitrary shape, so the unavoidable `any` and `Function` usages are marked with scoped `$FlowFixMe[unclear-type]` rather than tightened. `Dimensions.addEventListener` deliberately keeps its original `handler: Function` signature. Flow types object properties invariantly, so any precise payload annotation would reject existing subscribers that annotate the payload with their own object shapes, forcing unrelated call sites to change. The generated API snapshot is therefore unchanged for `Dimensions`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763789
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#57736 Upgrade the Settings modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]`. Changelog: [Internal] Reviewed By: javache Differential Revision: D113763793
rubennorte
force-pushed
the
export-D113763793
branch
from
September 8, 2026 17:07
45077f0 to
da86729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrade the Settings modules from
flowtoflow strict-local, preserving public type signatures so consumers are unaffected. Values read from the settings store are of arbitrary shape, so those internalanyusages are marked with scoped$FlowFixMe[unclear-type].Changelog: [Internal]
Reviewed By: javache
Differential Revision: D113763793