-
Notifications
You must be signed in to change notification settings - Fork 13
feat: [data-view, data-table, filter-chip] move dates off dayjs #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shreyag02
wants to merge
25
commits into
main
Choose a base branch
from
chore/calendar-preview-remove-dayjs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6186549
chore: [data-view, data-table, filter-chip] wip move dates onto date-…
Shreyag02 5d59778
chore: [data-view, data-table, filter-chip] compare dates by day and …
Shreyag02 94b3815
Merge branch 'main' into chore/calendar-preview-remove-dayjs
Shreyag02 a05872c
fix: [data-view, data-table] keep filter values and reject impossible…
Shreyag02 da945ae
chore: [changelog] note the date filter behaviour changes
Shreyag02 c8dc2d9
fix: [calendar-preview] reject an impossible day in every date form
Shreyag02 d162f07
fix: [data-view, data-table] filter a restored date filter by its date
Shreyag02 5b6db2b
feat: [filter-chip] render CalendarPreview for date filters
Shreyag02 8b6f98d
chore: [filter-chip] target the calendar-preview input in chip styles
Shreyag02 48fa1ea
feat: [filter-chip] restore slotProps, showCalendarIcon and onErrorCh…
Shreyag02 b6b64bd
chore: [filter-chip] document the calendarProps formatValue and slot …
Shreyag02 5d27fa3
fix: [calendar-preview] keep the popup shut when a controlled open cl…
Shreyag02 cfcb1c2
chore: [changelog] update the date filter and calendarProps notes
Shreyag02 cb0ef10
chore: [filter-chip] split the calendarProps demo into max date and c…
Shreyag02 23e6a41
fix: [calendar-preview, data-view, data-table] load on safari 15
Shreyag02 9002ba9
fix: [filter-chip] keep the date value stable and pass disabled to th…
Shreyag02 a314eb1
Merge branch 'main' into chore/calendar-preview-remove-dayjs
Shreyag02 5381203
refactor: [calendar-preview, data-view, filter-chip] keep date-adapte…
Shreyag02 b7e6952
fix: [filter-chip] do not crash on an invalid or out-of-range date
Shreyag02 cacf546
fix: [data-view, data-table] read dayjs and moment objects in date fi…
Shreyag02 839c1d4
fix: [data-view, data-table] simplify toInstant and keep month-bounda…
Shreyag02 d469b80
Merge branch 'main' into chore/calendar-preview-remove-dayjs
Shreyag02 c557fc4
fix: [data-view, filter-chip] read dayjs and moment objects in the ti…
Shreyag02 d1c845e
refactor: [data-view, data-table] share the date operators and remove…
Shreyag02 e078488
chore: [docs] clarify calendarProps and cleared-date notes in the upg…
Shreyag02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve the advertised date format in the replacement example.
The old example requests
YYYY-MM-DD.toLocaleDateString("en-CA", ...)does not guarantee that exact output across implementations. UseformatToPartsto constructYYYY-MM-DDif the example intends to preserve the displayed format. (developer.mozilla.org)🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't fix.
en-CAgivesYYYY-MM-DDin V8, SpiderMonkey and JavaScriptCore, andformatToPartswould make the migration example harder to read.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shreyag02Understood. I won’t press forformatToPartsin this migration example. Thanks for the guidance.✏️ Learnings added
You are interacting with an AI system.