Summary
Handle restored date filters when field metadata gains filterType: 'date' after mount in both DataTable and DataView.
- DataTable:
columns can gain date-filter metadata after DataTableRoot initializes tableQuery.
- DataView: root fields can change after mount, and a view's
fields override can register after the initial query loads. These changes affect effectiveFields.
In both cases, an untyped restored date filter can remain untyped. Client filtering can then match no rows, and server query emission can use string-filter behavior instead of date-filter behavior.
This limitation predates PR #919. The follow-up is separate from that PR.
Required changes
- Derive missing filter types from the current DataTable
columns and DataView effectiveFields when computing row-filter state and emitted queries.
- Use the shared date-filter metadata helper where appropriate.
- Preserve existing filter values, operators, explicit types, and user edits.
- Do not reinitialize
tableQuery from the original query or add an effect that replaces user edits.
- Ensure DataView uses the active view's effective metadata, including its
fields override.
Affected areas
- DataTable:
DataTableRoot, row-filter state derivation, and server query emission. The reviewed root file is packages/react/components/data-table/data-table.tsx.
- DataView:
DataViewRoot, effectiveFields, row-filter state derivation, and server query emission.
- Shared date-filter metadata helpers and DataTable/DataView regression tests.
Acceptance criteria
- Mount DataTable with an untyped restored date filter, then give its column
filterType: 'date'. Client filtering compares whole days and selects the expected rows.
- Repeat this scenario in DataView for both updated root fields and a view's late-registering
fields override.
- In server mode, both components emit the restored filter with date semantics and a viewer-local
YYYY-MM-DD stringValue after date metadata becomes available.
- Preserve the original filter
value and any user edits made before metadata arrives.
- Leave explicitly typed filters and unrelated filters unchanged.
- Add regression tests for both components, including client filtering and server query emission.
References
Requested by @Shreyag02.
Summary
Handle restored date filters when field metadata gains
filterType: 'date'after mount in both DataTable and DataView.columnscan gain date-filter metadata afterDataTableRootinitializestableQuery.fieldsoverride can register after the initial query loads. These changes affecteffectiveFields.In both cases, an untyped restored date filter can remain untyped. Client filtering can then match no rows, and server query emission can use string-filter behavior instead of date-filter behavior.
This limitation predates PR #919. The follow-up is separate from that PR.
Required changes
columnsand DataVieweffectiveFieldswhen computing row-filter state and emitted queries.tableQueryfrom the original query or add an effect that replaces user edits.fieldsoverride.Affected areas
DataTableRoot, row-filter state derivation, and server query emission. The reviewed root file ispackages/react/components/data-table/data-table.tsx.DataViewRoot,effectiveFields, row-filter state derivation, and server query emission.Acceptance criteria
filterType: 'date'. Client filtering compares whole days and selects the expected rows.fieldsoverride.YYYY-MM-DDstringValueafter date metadata becomes available.valueand any user edits made before metadata arrives.References
Requested by @Shreyag02.