Repository navigation
Fix Variable File Extension Matching - #123
Merged
Merged
Conversation
When processing copyright header substitutions by file extension, the replacement logic matched files by path suffix rather than by actual file extension. This caused false-positive matches in any case where one extension is a suffix of another (for example, h matching sh, c matching rc, and similar patterns). As a result, files can receive a header template intended for a different language, which leads to incorrect comment syntax and invalid or inconsistent generated source content. Header substitution should apply only to: Files with an exact extension match. Exact filename matches when filename-based filtering is used. This change fixes the wrong matching implementation. [CL]: Fixed variable file extension matching in replace_var() function. [#122] Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
kilo52
added
Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a faulty file extension matching in the
replace_var()function.When processing copyright header substitutions by file extension, the replacement logic matched files by path suffix rather than by actual file extension. This caused false-positive matches in any case where one extension is a suffix of another (for example, h matching sh, c matching rc, and similar patterns).
As a result, files can receive a header template intended for a different language, which leads to incorrect comment syntax and invalid or inconsistent generated source content.
Header substitution should apply only to:
Files with an exact extension match.
Exact filename matches when filename-based filtering is used.
This change fixes the wrong matching implementation.